Permissive Learning Mode 4/6 Capability#587
Open
lilybarkley-msft wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📖 Description
PR 4 of 6 — stacked on PR3. Adds capability extraction.
extract_capsmodule: decodes the DACL ACE blob attached to eachEventID=14event and resolves capability SIDs to names viaDeriveCapabilitySidsFromName.build_capability_table) so the per-event hot path avoids the syscall +LocalAlloc/LocalFreeround-trip.CapabilityIndexfor O(1) SID-bytes → name resolution per ACE.event_parser:ParsedEventgainscomplex_data_4_idx(index of the 5th<ComplexData>sibling — the ACE blob) so the largest per-event field is borrowed, not cloned.ParseAccumulatorgains the capability table/index.access_failure::consume_access_failurewalks the ACE blob throughextract_caps_with_index_intoand accumulatesrequested_capabilities.config::merge_capabilities— full body replaces the PR3 stub. Resolves the containment sub-object case-insensitively, dedupes case-insensitively, sorts via an allocation-free ASCII compare, and emits a stderr warning when the backend has nocapabilitiesarray.plm extract-capsCLI subcommand for parser debugging on a single hex ACE blob.UI policy lands in PR5.
🔗 References
user/lilybarkley/plm-pr3-config-gen)EventID=27decode +uiPolicymerge)🔍 Validation
cargo build -p plm --target x86_64-pc-windows-msvc— cleancargo fmt --all -- --check— cleancargo clippy -p plm --target x86_64-pc-windows-msvc --all-targets -- -D warnings— cleancargo test -p plm --target x86_64-pc-windows-msvc— 52 passed (15 new: ACE blob decode, capability dedupe/sort,merge_capabilitieswith mixed-case inputs and unsupported-backend warning path).✅ Checklist
📋 Issue Type
GitHub Actions runs the PR validation build automatically. The ADO pipeline
(
MXC-PR-Build) is the official build pipeline that signs the binaries; itruns on merge to
mainand nightly, and Microsoft reviewers can trigger iton a PR with
/azp run. See docs/pull-requests.md.Microsoft Reviewers: Open in CodeFlow