chore: require playwright>=1.60 in CI and unskip 1.60 tests#313
Merged
Conversation
Playwright Python 1.60 has been released, so the tests gated on it can now run. Pin the dev dependency in local-requirements.txt so CI installs a compatible version; the package's runtime requirement is unchanged. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
dgozman
approved these changes
May 18, 2026
BrowserType.connect() renamed its first parameter from ws_endpoint to endpoint (positional) in microsoft/playwright-python#3050. The test also needs to look at stderr from the subprocess pytester run, since the WebSocket error log lands there. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Pytester decodes subprocess stdout as utf-8, but on Windows the default stdout encoding is cp1252. When Playwright's assertion failure messages contain non-ASCII characters (e.g. unicode arrows / multiplication signs), pytester raises UnicodeDecodeError. Force utf-8 in child Python processes. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
dgozman
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Playwright Python 1.60 has been released, so the tests gated on it can now run. Pin the dev dependency in
local-requirements.txtso CI installs a compatible version; the package's runtime requirement (playwright>=1.18) is unchanged.