Skip to content

test(mcp): hash outputDir into PLAYWRIGHT_SOCKETS_DIR #40636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Skn0tt merged 1 commit into from
May 6, 2026
Merged

test(mcp): hash outputDir into PLAYWRIGHT_SOCKETS_DIR #40636

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion tests/mcp/cli-fixtures.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
* limitations under the License.
*/

import crypto from 'crypto';
import fs from 'fs';
import os from 'os';
import path from 'path';
Expand Down Expand Up @@ -118,7 +119,11 @@ function cliEnv() {
PLAYWRIGHT_SERVER_REGISTRY: test.info().outputPath('registry'),
PWTEST_DASHBOARD_SETTINGS_FILE: test.info().outputPath('dashboard.settings.json'),
PLAYWRIGHT_DAEMON_SESSION_DIR: test.info().outputPath('daemon'),
PLAYWRIGHT_SOCKETS_DIR: path.join(os.tmpdir(), 'ds' + String(test.info().workerIndex)),
// Include a short hash of outputDir so that concurrent runs from different
// checkouts use different socket directories, while runs within the same
// checkout share them (which helps surface race conditions and cleanup
// issues). The hash is kept short to stay clear of socket path length limits.
PLAYWRIGHT_SOCKETS_DIR: path.join(os.tmpdir(), 'ds' + String(test.info().workerIndex) + '-' + crypto.createHash('sha1').update(test.info().outputDir).digest('hex').slice(0, 8)),
PWTEST_CLI_CHANNEL_SCAN_DISABLED_FOR_TEST: '1',
};
}
Expand Down
Loading