Skip to content

fix(dashboard): retry singleton listen with backoff on Windows shutdown race #40641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Skn0tt wants to merge 1 commit into from
+13 −2
Closed

fix(dashboard): retry singleton listen with backoff on Windows shutdown race #40641

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions packages/playwright-core/src/tools/dashboard/dashboardApp.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,7 +278,12 @@ async function acquireSingleton(options: DashboardOptions): Promise<net.Server>

return await new Promise((resolve, reject) => {
const server = net.createServer();
server.listen(socketPath, () => resolve(server));
let listenRetries = 0;

const tryListen = () => {
server.listen(socketPath, () => resolve(server));
};

server.on('error', (err: NodeJS.ErrnoException) => {
const isInUse = err.code === 'EADDRINUSE'
|| (process.platform === 'win32' && err.code === 'EBUSY');
Expand All @@ -291,9 +296,15 @@ async function acquireSingleton(options: DashboardOptions): Promise<net.Server>
client.on('error', () => {
if (process.platform !== 'win32')
fs.unlinkSync(socketPath);
server.listen(socketPath, () => resolve(server));
// On Windows the previous server may still be shutting down; retry with backoff.
if (listenRetries >= 5)
return reject(err);
const delay = Math.min(100 * (1 << listenRetries++), 3000);
setTimeout(tryListen, delay);
});
});

tryListen();
});
}

Expand Down
Loading