Revert "fix(dashboard): close server in singleton handler on shutdown (#40626)"#40663
Closed
Skn0tt wants to merge 1 commit intomicrosoft:mainfrom
Closed
Revert "fix(dashboard): close server in singleton handler on shutdown (#40626)"#40663Skn0tt wants to merge 1 commit intomicrosoft:mainfrom
Skn0tt wants to merge 1 commit intomicrosoft:mainfrom
Conversation
…microsoft#40626)" This reverts commit f536e37.
Member
Author
|
Superseded by #40642 |
Contributor
Test results for "MCP"4 failed 6939 passed, 1052 skipped Merge workflow run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #40626 — the EBUSY check and
server?.close()in the kill handler added there are not needed. The real fix for the Windows named pipe race is in #40642.