fix(webview): page.getContentQuads should work for elements inside <iframe>#41437
Open
dcrousso wants to merge 1 commit into
Open
fix(webview): page.getContentQuads should work for elements inside <iframe>#41437dcrousso wants to merge 1 commit into
page.getContentQuads should work for elements inside <iframe>#41437dcrousso wants to merge 1 commit into
Conversation
…`<iframe>` leverage `elementFromPoint`, `getBoundingClientRect`, and `getComputedStyle` to manually compute the offsets of each ancestor `<iframe>`
Contributor
Test results for "MCP"7380 passed, 1122 skipped Merge workflow run. |
Contributor
Test results for "tests 1"2 failed 3 flaky49047 passed, 1142 skipped Merge workflow run. |
| let frameDoc: Document | null = null; | ||
| let frameView: (Window & typeof globalThis) | null = null; | ||
| try { | ||
| frameDoc = frame.contentDocument; |
Member
There was a problem hiding this comment.
This branch is unlikely to work as iframes are typically cross-origin.
| target.value = target.value.slice(0, start) + text + target.value.slice(end); | ||
| if (!target) | ||
| return; | ||
| const view = target.ownerDocument.defaultView; |
Member
There was a problem hiding this comment.
This looks like a part of a separate change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
leverage
elementFromPoint,getBoundingClientRect, andgetComputedStyleto manually compute the offsets of each ancestor<iframe>