Skip to content

feat(chromium): roll to r1240 - #42246

Open
microsoft-playwright-automation[bot] wants to merge 1 commit into
mainfrom
roll-into-pw-chromium/1240
Open

feat(chromium): roll to r1240#42246
microsoft-playwright-automation[bot] wants to merge 1 commit into
mainfrom
roll-into-pw-chromium/1240

Conversation

@microsoft-playwright-automation

Copy link
Copy Markdown
Contributor

Browser build: https://github.com/microsoft/playwright-browsers/commit/585288252a830c4c3ed84857c484c4a71a239adc. Build has full platform coverage - check that all tests pass there.

@github-actions

Copy link
Copy Markdown
Contributor

Test results for "tests 1"

1 failed
❌ [playwright-test] › reporter.spec.ts:251 › merged › should not have internal error when steps are finished after timeout @windows-latest-node22

8 flaky ⚠️ [chromium-library] › library/video.spec.ts:699 › screencast › should capture full viewport on hidpi `@chromium-ubuntu-22.04-arm-node20`
⚠️ [chromium-library] › library/video.spec.ts:356 › screencast › should work for popups `@realtime-time-library-chromium-linux`
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:373 › should produce network events, routing, and annotations for Service Worker `@chromium-ubuntu-22.04-node24`
⚠️ [chromium-library] › library/browsercontext-page-event.spec.ts:173 › should work with Ctrl-clicking `@chromium-ubuntu-22.04-node20`
⚠️ [chromium-library] › library/video.spec.ts:294 › screencast › should capture navigation `@chromium-ubuntu-22.04-node20`
⚠️ [chromium-library] › library/video.spec.ts:495 › screencast › should capture static page in persistent context Radoslav Kirilov (@smoke) `@chromium-ubuntu-22.04-node22`
⚠️ [chromium-library] › library/video.spec.ts:664 › screencast › should capture full viewport `@chromium-ubuntu-22.04-node22`
⚠️ [playwright-test] › ui-mode-trace.spec.ts:189 › should show snapshots for steps `@windows-latest-node22`

51116 passed, 1208 skipped


Merge workflow run.

@github-actions

Copy link
Copy Markdown
Contributor

Hi, I'm the Playwright bot and I took a look at the CI failures here.

🟢 The one failure is a pre-existing Windows flake — this roll is clear

reporter.spec.ts:251 › merged › should not have internal error when steps are finished after timeout timed out on windows-latest-node22. That test has nothing to do with a Chromium roll, and it flakes on that exact bot on unrelated SHAs.

Details

This PR is a Chromium roll to r1240 — it only touches README.md and the browser version manifests. The single failure is in the playwright-test reporter suite (merged reports, steps after timeout), which never exercises a browser, so the roll can't reach it.

Pre-existing flake / infra

  • [playwright-test] › reporter.spec.ts:251 › merged › should not have internal error when steps are finished after timeout (@windows-latest-node22) — pre-existing flake. Across the test-results DB this test is passed 4706 of 4710 runs (99.9%); all 4 failures are timedOut on windows-latest-node22, on unrelated work: PR docs(locator): drop type markup from ariaSnapshotJSON details #42136 (sha 62187ef5), PR test: test for issue 41348 #41930 (sha 81330e36), a push run (sha ac877bc1), and this PR. Windows-only, timeout signature, spread across unrelated SHAs — a flaky test, not this roll.

The 8 flaky entries in the report all passed on retry and need no triage.

Triaged by the Playwright bot - agent run

@github-actions

Copy link
Copy Markdown
Contributor

Test results for "MCP"

1 failed
❌ [firefox] › mcp/cli-session.spec.ts:162 › list --all lists sessions from all workspaces @mcp-windows-latest-firefox

8100 passed, 1311 skipped


Merge workflow run.

@github-actions

Copy link
Copy Markdown
Contributor

Hi, I'm the Playwright bot and I took a look at the CI failures here.

🟢 Both failures are unrelated to this roll — it's clear

This PR is a Chromium roll to r1240: the diff is only README.md and the browser version manifests, with no product code. Neither failing test launches Chromium, so the roll can't reach either.

Details

Two separate reports each flagged one failure. A pure Chromium version bump can't change a playwright-test reporter test or a Firefox MCP test, and both have supporting flake evidence.

Pre-existing flake / infra

  • [playwright-test] › reporter.spec.ts:251 › merged › should not have internal error when steps are finished after timeout (@windows-latest-node22) — timed out. This suite never launches a browser. Across the test-results DB the test is passed 4710 of 4710 runs in the current window (and it's a known Windows-only timeout flake on that exact bot). Windows-only + timeout signature + a Chromium-manifest-only diff = not this roll.

  • [firefox] › mcp/cli-session.spec.ts:162 › list --all lists sessions from all workspaces (@mcp-windows-latest-firefox) — this is a Firefox MCP test; a Chromium roll can't affect it. The failure is a session-isolation assertion (expect(...).not.toContain("workspace1")), i.e. a workspace leaking between sessions — browser-agnostic MCP logic, not a browser behavior. The same test also failed on an unrelated push run (sha 4a0c4e4e, mcp-macos-latest-chrome, timedOut), so it flakes independently of this PR. Across the DB it's passed 9461 of 9463 runs (99.98%).

The flaky entries in the first report all passed on retry and need no triage.

Triaged by the Playwright bot - agent run

@github-actions

Copy link
Copy Markdown
Contributor

Test results for "tests 2"

5 failed
❌ [chromium-library] › library/multiclient.spec.ts:364 › should avoid side effects upon disconnect @tracing-chromium
❌ [chromium-page] › page/page-click.spec.ts:1380 › should throw an Error when aborted in-flight with a string reason @tracing-chromium
❌ [firefox-library] › library/multiclient.spec.ts:364 › should avoid side effects upon disconnect @tracing-firefox
❌ [firefox-page] › page/page-click.spec.ts:1380 › should throw an Error when aborted in-flight with a string reason @tracing-firefox
❌ [webkit-page] › page/page-click.spec.ts:1380 › should throw an Error when aborted in-flight with a string reason @tracing-webkit

25 flaky ⚠️ [chromium-library] › library/popup.spec.ts:260 › should not throw when click closes popup `@tracing-chromium`
⚠️ [chromium-page] › page/page-screenshot.spec.ts:504 › page screenshot › should take fullPage screenshots during navigation `@tracing-chromium`
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:436 › should produce network events, routing, and annotations for Service Worker (advanced) `@chrome-ubuntu-22.04`
⚠️ [chromium-library] › library/chromium/connect-over-cdp.spec.ts:523 › emulate media should not be affected by second connectOverCDP with noDefaults `@msedge-windows-latest`
⚠️ [chromium-library] › library/downloads-path.spec.ts:91 › downloads path › should accept downloads in persistent context `@msedge-windows-latest`
⚠️ [chromium-library] › library/video.spec.ts:495 › screencast › should capture static page in persistent context Radoslav Kirilov (@smoke) `@msedge-windows-latest`
⚠️ [chromium-library] › library/chromium/oopif.spec.ts:150 › should take screenshot `@chromium-macos-14-xlarge`
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:179 › serviceWorker(), and fromServiceWorker() work `@chromium-macos-15-xlarge`
⚠️ [chromium-library] › library/video.spec.ts:736 › screencast › should work with video+trace `@chromium-macos-15-xlarge`
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:301 › should report intercepted service worker requests in HAR `@chrome-beta-ubuntu-22.04`
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:179 › serviceWorker(), and fromServiceWorker() work `@chrome-macos-latest`
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:436 › should produce network events, routing, and annotations for Service Worker (advanced) `@chrome-macos-latest`
⚠️ [chromium-library] › library/selector-generator.spec.ts:121 › selector generator › should fall back to nth when name and description are both not unique `@chrome-macos-latest`
⚠️ [chromium-library] › library/selector-generator.spec.ts:190 › selector generator › should escape text with slash `@chrome-macos-latest`
⚠️ [chromium-library] › library/selector-generator.spec.ts:641 › selector generator › should generate exact label when necessary `@chrome-macos-latest`
⚠️ [chromium-library] › library/selector-generator.spec.ts:693 › selector generator › should generate noText: ignore aria-labelledby pointing inside the element `@chrome-macos-latest`
⚠️ [chromium-library] › library/selector-generator.spec.ts:736 › selector generator › should not use icon fonts aria name `@chrome-macos-latest`
⚠️ [chromium-library] › library/trace-viewer.spec.ts:2304 › should load trace from HTTP with progress indicator `@chrome-macos-latest`
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:373 › should produce network events, routing, and annotations for Service Worker `@driver`
⚠️ [firefox-library] › library/browsertype-launch-server.spec.ts:94 › launch server › should fire close event `@tracing-firefox`
⚠️ [firefox-page] › page/page-event-request.spec.ts:181 › should return response body when Cross-Origin-Opener-Policy is set `@firefox-macos-15-large`
⚠️ [firefox-library] › library/browsercontext-reuse.spec.ts:155 › reuse launch › should reset serviceworker that hangs in importScripts `@firefox-windows-latest`
⚠️ [webkit-library] › library/multiclient.spec.ts:364 › should avoid side effects upon disconnect `@tracing-webkit`
⚠️ [webkit-library] › library/playwright-client.spec.ts:26 › should connect from a page and drive the same browser `@tracing-webkit`
⚠️ [android-page] › page/page-request-fulfill.spec.ts:81 › should fulfill with unuassigned status codes

110450 passed, 4644 skipped


Merge workflow run.

@github-actions

Copy link
Copy Markdown
Contributor

Hi, I'm the Playwright bot and I took a look at the CI failures here.

🟢 Both failures are pre-existing @tracing flakes — this roll is clear

This PR is a Chromium roll to r1240: the diff is only README.md and the browser version manifests, no product code. Both failing tests also fail on Firefox and WebKit, which a Chromium bump can't touch, and both have long flake histories on unrelated PRs.

Details

The report has two failure stories, each landing only on the @tracing-* jobs and each spread across chromium/firefox/webkit — the tell-tale of a tracing-shard flake rather than an engine change. A Chromium version bump can't reach Firefox or WebKit at all.

Pre-existing flake / infra

  • library/multiclient.spec.ts:364 › should avoid side effects upon disconnect (@tracing-chromium, @tracing-firefox; also flaky on @tracing-webkit in this same report) — across the test-results DB this test is passed 11253 of 11322 runs (99.4%), failing on unrelated work: e.g. Firefox on PRs test: test for issue 41348 #41930-era SHAs and scheduled bidi-chromium-library runs (shas b2743b22, 3afd6cee, d448aac0). Firefox alone accounts for 42 distinct failing SHAs. The Firefox/WebKit failures can't be a Chromium roll.

  • page/page-click.spec.ts:1380 › should throw an Error when aborted in-flight with a string reason (@tracing-chromium, @tracing-firefox, @tracing-webkit) — passed 12895 of 13030 runs (99.0%). It fails on all three engines together on unrelated PRs — e.g. PR feat(webkit): roll to r2346 #42210 (sha c7c254ab) and PR chore(deps-dev): bump @hono/node-server from 1.19.14 to 1.19.17 #42225 (sha 0ab5720f) each timedOut on tracing-chromium, tracing-firefox, and tracing-webkit at once. A test that times out on every browser simultaneously on other people's PRs is a tracing-job flake, not this roll.

The 25 flaky entries in the report all passed on retry and need no triage.

Triaged by the Playwright bot - agent run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants