Open
Conversation
📊 Coverage Summary
Detailed Coverage ReportsC++ Coverage DetailsPython Coverage DetailsPybind11 Coverage Details |
mmoerchen
requested review from
ConradJohnston,
nabbelbabbel,
sobolevnrm and
wavefunction91
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
Adds lattice spin-model Hamiltonian builders (Heisenberg/Ising) to the Python utilities layer, alongside validation/broadcast helpers in the C++/pybind model-hamiltonians bindings, with new integration tests to validate generated Pauli terms.
Changes:
- Add
create_heisenberg_hamiltonianandcreate_ising_hamiltonianPython utilities returningQubitHamiltonian. - Expose/route
to_site_paramandto_pair_paramutilities through the pybind model_hamiltonians module and strengthen C++ validation. - Add new tests for Ising and Heisenberg chains (including weighted-edge lattices).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| python/tests/test_model_hamiltonians.py | Adds integration tests asserting Pauli-term structure for Ising/Heisenberg models. |
| python/src/qdk_chemistry/utils/model_hamiltonians.py | Implements Heisenberg/Ising Hamiltonian construction via PauliOperator expressions and conversion to QubitHamiltonian. |
| python/src/pybind11/utils/model_hamiltonians.cpp | Adds to_site_param/to_pair_param bindings and uses them in existing factories/potentials. |
| cpp/include/qdk/chemistry/utils/model_hamiltonians.hpp | Refactors parameter broadcasting to validate against lattice size and adds trace logging in builders. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.