Skip to content

fix(apple): always enable Hermes from 0.80+ #2444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tido64 merged 2 commits into from
Apr 9, 2025
Merged

fix(apple): always enable Hermes from 0.80+ #2444

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
52e2cd2
fix(apple): always enable Hermes from 0.80+
tido64 Apr 9, 2025
0f088c2
update tests
tido64 Apr 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 17 additions & 9 deletions ios/features.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,16 +60,24 @@ export function isBridgelessEnabled(reactNativeVersion, options) {
* @returns {boolean | "from-source"}
*/
export function isHermesEnabled(platform, reactNativeVersion, options) {
const useHermes = process.env["USE_HERMES"];
const enabled =
typeof useHermes === "string"
? useHermes === "1"
: options["hermesEnabled"] === true;
if (reactNativeVersion < v(0, 80, 0)) {
const useHermes = process.env["USE_HERMES"];
const enabled =
typeof useHermes === "string"
? useHermes === "1"
: options["hermesEnabled"] === true;

// Hermes prebuilds for visionOS was introduced in 0.76
if (enabled && platform === "visionos" && reactNativeVersion < v(0, 76, 0)) {
return "from-source";
// Hermes prebuilds for visionOS was introduced in 0.76
if (
enabled &&
Copy link
Copy Markdown

@JasonVMo JasonVMo Apr 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be better to centralize these types of settings into capabilities. Maybe a function that returns an object with various capabilities given a RN version and process.env settings. It ends up being easier to manage. Doesn't need to be done now but something for you to consider.

Copy link
Copy Markdown
Member Author

@tido64 tido64 Apr 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's what this function is used for. See https://github.com/microsoft/react-native-test-app/blob/trunk/ios/app.mjs#L236-L255 and the tests in https://github.com/microsoft/react-native-test-app/blob/trunk/test/ios/app.test.ts

platform === "visionos" &&
reactNativeVersion < v(0, 76, 0)
) {
return "from-source";
}

return enabled;
}

return enabled;
return true;
}
14 changes: 7 additions & 7 deletions test/ios/app.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,7 +268,7 @@ const PROJECT_FILES = {
testsBuildSettings: {},
uitestsBuildSettings: {},
useBridgeless: true,
useHermes: false,
useHermes: true,
useNewArch: true,
xcodeprojPath: "/~/node_modules/.generated/ios/ReactTestApp.xcodeproj",
},
Expand Down Expand Up @@ -297,7 +297,7 @@ const PROJECT_FILES = {
testsBuildSettings: {},
uitestsBuildSettings: {},
useBridgeless: true,
useHermes: false,
useHermes: true,
useNewArch: true,
xcodeprojPath: "/~/node_modules/.generated/ios/ReactTestApp.xcodeproj",
},
Expand Down Expand Up @@ -362,7 +362,7 @@ const PROJECT_FILES = {
testsBuildSettings: {},
uitestsBuildSettings: {},
useBridgeless: true,
useHermes: false,
useHermes: true,
useNewArch: true,
xcodeprojPath:
"/~/node_modules/.generated/macos/ReactTestApp.xcodeproj",
Expand Down Expand Up @@ -428,7 +428,7 @@ const PROJECT_FILES = {
testsBuildSettings: {},
uitestsBuildSettings: {},
useBridgeless: true,
useHermes: false,
useHermes: true,
useNewArch: true,
xcodeprojPath:
"/~/node_modules/.generated/visionos/ReactTestApp.xcodeproj",
Expand Down Expand Up @@ -490,7 +490,7 @@ const PROJECT_FILES = {
testsBuildSettings: {},
uitestsBuildSettings: {},
useBridgeless: false,
useHermes: false,
useHermes: true,
useNewArch: false,
xcodeprojPath: "/~/node_modules/.generated/ios/ReactTestApp.xcodeproj",
},
Expand Down Expand Up @@ -549,7 +549,7 @@ const PROJECT_FILES = {
testsBuildSettings: {},
uitestsBuildSettings: {},
useBridgeless: false,
useHermes: false,
useHermes: true,
useNewArch: false,
xcodeprojPath:
"/~/node_modules/.generated/macos/ReactTestApp.xcodeproj",
Expand Down Expand Up @@ -609,7 +609,7 @@ const PROJECT_FILES = {
testsBuildSettings: {},
uitestsBuildSettings: {},
useBridgeless: false,
useHermes: false,
useHermes: true,
useNewArch: false,
xcodeprojPath:
"/~/node_modules/.generated/visionos/ReactTestApp.xcodeproj",
Expand Down
26 changes: 17 additions & 9 deletions test/ios/features.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,31 +55,39 @@ describe("isBridgelessEnabled()", () => {
});

describe("isHermesEnabled()", () => {
before(() => {
function resetEnvironmentVariables() {
delete process.env["USE_HERMES"];
});
}

afterEach(() => {
delete process.env["USE_HERMES"];
});
before(resetEnvironmentVariables);

afterEach(resetEnvironmentVariables);

for (const platform of ["ios", "macos", "visionos"] as const) {
it(`[${platform}] is disabled by default`, () => {
ok(!isHermesEnabled(platform, v(1, 0, 0), {}));
ok(!isHermesEnabled(platform, v(0, 79, 0), {}));
});

it(`[${platform}] returns true when enabled`, () => {
ok(isHermesEnabled(platform, v(1, 0, 0), { hermesEnabled: true }));
ok(isHermesEnabled(platform, v(0, 79, 0), { hermesEnabled: true }));
});

it(`[${platform}] returns true if 'USE_HERMES=1'`, () => {
process.env["USE_HERMES"] = "1";
ok(isHermesEnabled(platform, v(1, 0, 0), {}));
ok(isHermesEnabled(platform, v(0, 79, 0), {}));
});

it(`[${platform}] returns false if 'USE_HERMES=0'`, () => {
process.env["USE_HERMES"] = "0";
ok(!isHermesEnabled(platform, v(1, 0, 0), { hermesEnabled: true }));
ok(!isHermesEnabled(platform, v(0, 79, 0), { hermesEnabled: true }));
});

it(`[${platform}] always returns true from 0.80 on`, () => {
ok(isHermesEnabled(platform, v(0, 80, 0), {}));

process.env["USE_HERMES"] = "0";

ok(isHermesEnabled(platform, v(0, 80, 0), {}));
});
}

Expand Down
Loading