Fix CodeQL cs/microsoft/sql-injection false positives (SM03934)#2621
Open
Fix CodeQL cs/microsoft/sql-injection false positives (SM03934)#2621
Conversation
kburtram
requested review from
Benjin,
aasimkhan30,
allancascante,
caohai,
laurenastrid1,
lewis-sanchez,
llali,
manujoseph85 and
ssreerama
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Suppress two CodeQL sql-injection alerts that are intentional by design:
ReliableSqlCommand.CommandText setter — this class wraps SqlCommand for reliable execution; accepting user SQL is its entire purpose.
Batch.cs localCommand.CommandText = script — this is the batch execution engine; executing user-supplied SQL scripts is what it does.
Both suppressions use inline // CodeQL [SM03934] comments with justifications explaining the intentional design, rather than blanket SuppressMessage attributes, so the rationale is visible at the point of use.