[http-client-csharp] Preserve enum type when @alternateType collapses single-member enum to constant#10281
Draft
[http-client-csharp] Preserve enum type when @alternateType collapses single-member enum to constant#10281
Conversation
…num to constant Agent-Logs-Url: https://github.com/microsoft/typespec/sessions/f1259764-9aff-4b82-87b9-341ba62673a2 Co-authored-by: live1206 <5196139+live1206@users.noreply.github.com>
…iew feedback Agent-Logs-Url: https://github.com/microsoft/typespec/sessions/f1259764-9aff-4b82-87b9-341ba62673a2 Co-authored-by: live1206 <5196139+live1206@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix single-member enum collapsing to constant instead of preserving type
[http-client-csharp] Preserve enum type when @alternateType collapses single-member enum to constant
Apr 7, 2026
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
@alternateType("green")is applied to a required property of typeColors(a single-member enum), TCGC resolves it as anSdkConstantTypeinstead ofSdkEnumType. The emitter'scase "constant":branch only promoted constants to extensible enums for optional/nullable properties, so required properties collapsed to string literals.Changes
emitter/src/lib/type-converter.ts: In thecase "constant":branch, checksdkProperty.__raw?.type?.kind === "Enum"to detect when the original TypeSpec property type was an enum. When true, convert to extensible enum regardless of optionality.emitter/test/Unit/constant-type.test.ts: Added test for single-member enum with@alternateTypeon a required property, assertingkind === "enum"andisFixed === false.Repro
Before:
favoriteColoremitted as constant"green"After:
favoriteColoremitted as extensible enum type