Skip to content

chore: skip external reviewer pings on draft PRs #11385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −2
Draft

chore: skip external reviewer pings on draft PRs #11385

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/policies/prs.external-reviewers.generated.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ configuration:
- not:
hasLabel:
label: emitter:graphql
- not: isDraft
then:
- addReply:
reply: "@fionabronwen @swatkatz @steverice — this PR modifies files in the
Expand Down
2 changes: 1 addition & 1 deletion eng/common/scripts/labels/automation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@ function createExternalReviewersConfig(config: RepoConfig): PolicyServiceConfig
// on every subsequent push (the prs.triage policy also adds it, but adding
// it here guarantees the guard is set even if that policy hasn't run yet).
return {
if: [includesModifiedFiles(globs), not(hasLabel(area))],
if: [includesModifiedFiles(globs), not(hasLabel(area)), not("isDraft")],
then: [
addReply(
`${mentions} — this PR modifies files in the \`${area}\` area, which your team owns. Please take a look. (You can't be added as a formal reviewer because you're not a repository collaborator, so this is a heads-up instead.)`,
Expand Down
3 changes: 2 additions & 1 deletion eng/common/scripts/labels/policy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,8 @@ export type Condition =
| And
| Not
| "isAssignedToSomeone"
| "isOpen";
| "isOpen"
| "isDraft";

export function payloadType(payloadType: PayloadType["payloadType"]): PayloadType {
return {
Expand Down
Loading