Skip to content

Update Detours#50487

Merged
vicroms merged 3 commits intomicrosoft:masterfrom
dongle-the-gadget:update-detours
Mar 18, 2026
Merged

Update Detours#50487
vicroms merged 3 commits intomicrosoft:masterfrom
dongle-the-gadget:update-detours

Conversation

@dongle-the-gadget
Copy link
Copy Markdown
Contributor

Fixes #45889

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version, or no changes were necessary.
  • Any fixed CI baseline and CI feature baseline entries are removed from that file, or no entries needed to be changed.
  • All patch files in the port are applied and succeed.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Exactly one version is added in each modified versions file.

Copy link
Copy Markdown
Member

@vicroms vicroms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A contributor has asked about a new release version recently: microsoft/Detours#371. So, we may a few days for upstream to respond.

HEAD_REF master
PATCHES
find-jmp-bounds-arm64.patch
REF 9764cebcb1a75940e68fa83d6730ffaf0f669401
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This moves us from the official release tag.

Comment thread ports/detours/vcpkg.json Outdated
@@ -1,7 +1,7 @@
{
"name": "detours",
"version": "4.0.1",
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"version": "4.0.1",
"version-date": "2025-06-20",

Since we are moving away from the official release version, we should reflect that with a version scheme change. Version 4.0.1 was published in 2018 but the project has had many commits merged since.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upon further investigation, it looks like upstream has been asked to create a new release tag many times before (even mentioning vcpkg: microsoft/Detours#360). So, let's not delay and just adopt version-date for this port from now on.

@vicroms vicroms marked this pull request as draft March 17, 2026 21:32
@dongle-the-gadget
Copy link
Copy Markdown
Contributor Author

The upstream release had been very outdated so far, and the current version in vcpkg has an access violation bug for ARM64 machines in some scenarios.

@vicroms vicroms marked this pull request as ready for review March 18, 2026 19:15
@vicroms vicroms enabled auto-merge (squash) March 18, 2026 19:15
@vicroms vicroms merged commit 5becb67 into microsoft:master Mar 18, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[detours] update to include latest repo changes

2 participants