libstatgrab port#50496
Draft
Michael-Becerra wants to merge 3 commits intomicrosoft:masterfrom
Draft
Conversation
Member
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
vicroms
reviewed
Mar 20, 2026
Member
vicroms
left a comment
There was a problem hiding this comment.
I see a bunch of patches to the product code. Have you tried pushing these patches upstream? Although simple, there are many and they add up; if possible, we want the port to remain as close to upstream as possible.
Comment on lines
+45
to
+51
| +/* | ||
| + unsigned valid[(VECTOR_ITEM_COUNT(tmp) / (8 * sizeof(unsigned))) + 1]; | ||
|
|
||
| memset( valid, 0, sizeof(valid) ); | ||
| - | ||
| +*/ | ||
| + unsigned* valid = (unsigned*)calloc((VECTOR_ITEM_COUNT(tmp) / (8 * sizeof(unsigned))) + 1, sizeof(unsigned)); |
Member
There was a problem hiding this comment.
Have you tried pushing this patch to upstream?
Author
There was a problem hiding this comment.
i have not attempted to push these up I will see if i can push these upstream.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Owner-Projectform.vcpkg.json, or explicitly disabled through patches or build system arguments such as CMAKE_DISABLE_FIND_PACKAGE_Xxx or VCPKG_LOCK_FIND_PACKAGEvcpkg.jsonmatches what upstream says.vcpkg.jsonmatches what upstream says../vcpkg x-add-version --alland committing the result.