refactor: move branchDataProvider declaration above tryFindRevealedResource closure#2941
Merged
Merged
Conversation
…source Co-authored-by: mkrueger <341098+mkrueger@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] WIP Address feedback on vscode uri handler sign-in changes
refactor: move Feb 27, 2026
branchDataProvider declaration above tryFindRevealedResource closure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tryFindRevealedResourceclosed overbranchDataProviderwhich was declared after it, creating a TDZ hazard that was safe only due to call order — easy to break silently on refactor.Changes
src/vscodeUriHandler.ts(revealAzureResourceInExplorer):branchDataProviderdeclaration abovetryFindRevealedResourceso the captured variable is initialized before the closure is definedresourceto a single declaration + assignment:let resource = await tryFindRevealedResource()🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.