Skip to content

refactor: move branchDataProvider declaration above tryFindRevealedResource closure#2941

Merged
mkrueger merged 2 commits into
dev/mkrueger/issue2686from
copilot/sub-pr-2899
Feb 27, 2026
Merged

refactor: move branchDataProvider declaration above tryFindRevealedResource closure#2941
mkrueger merged 2 commits into
dev/mkrueger/issue2686from
copilot/sub-pr-2899

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Feb 27, 2026

tryFindRevealedResource closed over branchDataProvider which was declared after it, creating a TDZ hazard that was safe only due to call order — easy to break silently on refactor.

Changes

  • src/vscodeUriHandler.ts (revealAzureResourceInExplorer):
    • Moved branchDataProvider declaration above tryFindRevealedResource so the captured variable is initialized before the closure is defined
    • Simplified resource to a single declaration + assignment: let resource = await tryFindRevealedResource()
// Before
const tryFindRevealedResource = async () => {
    return await branchDataProvider.findNodeById(fulId); // closes over var declared below ⚠️
};

let resource: TreeElement | undefined;
const branchDataProvider = ...;
resource = await tryFindRevealedResource();

// After
const branchDataProvider = ...;

const tryFindRevealedResource = async () => {
    return await branchDataProvider.findNodeById(fulId); // declared above ✓
};

let resource: TreeElement | undefined = await tryFindRevealedResource();

🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.

…source

Co-authored-by: mkrueger <341098+mkrueger@users.noreply.github.com>
Copilot AI changed the title [WIP] WIP Address feedback on vscode uri handler sign-in changes refactor: move branchDataProvider declaration above tryFindRevealedResource closure Feb 27, 2026
@mkrueger mkrueger marked this pull request as ready for review February 27, 2026 11:32
@mkrueger mkrueger requested a review from a team as a code owner February 27, 2026 11:32
@mkrueger mkrueger merged commit 50dba85 into dev/mkrueger/issue2686 Feb 27, 2026
1 check passed
@mkrueger mkrueger deleted the copilot/sub-pr-2899 branch February 27, 2026 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants