Use locked VSCE installs and verify VSIX signatures - #14706
Draft
Sean McManus (sean-mcmanus) wants to merge 2 commits into
Draft
Use locked VSCE installs and verify VSIX signatures#14706Sean McManus (sean-mcmanus) wants to merge 2 commits into
Sean McManus (sean-mcmanus) wants to merge 2 commits into
Conversation
Copilot started reviewing on behalf of
Sean McManus (sean-mcmanus)
August 25, 2026 03:05
View session
Contributor
There was a problem hiding this comment.
Pull request overview
Uses reviewed VSCE lockfiles for deterministic packaging and verifies signed VSIX triplets at both release boundaries.
Changes:
- Replaces ad hoc VSCE installs with
npm ci. - Rebuilds the signer and verifies signatures after signing and before publishing.
- Configures each release pipeline’s source directory.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
Build/publish/jobs_publish_vsix.yml |
Installs locked dependencies and verifies signatures before upload. |
Build/publish/cpptools_themes.yml |
Selects the Themes lockfile directory. |
Build/publish/cpptools_extension_pack.yml |
Selects the Extension Pack lockfile directory. |
Build/package/jobs_package_vsix.yml |
Uses locked installs and verifies newly signed artifacts. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Install the Extension Pack and Themes packaging tools from their reviewed npm lockfiles, while retaining the explicit
@vscode/vsce-signrebuild required byignore-scripts=true. Verify each detached VSIX/manifest/P7S triplet immediately after signing and again before Marketplace upload.Marketplace signature validation remains the authoritative release gate. The post-sign check fails earlier, before a malformed or mismatched triplet becomes a pipeline artifact or enters manual release validation; the release-job check detects an incorrect or damaged triplet at the build-to-release transfer boundary and reports the failure locally before upload. These checks improve artifact assurance and failure diagnosis rather than replacing Marketplace verification.
This separates and extends the deterministic packaging work first exercised in #14701.
Validation
npm ci --include=dev --include=optionalinstalls forExtensionPackandThemes.@vscode/vsce-sign, confirmed the platform signer was installed, and confirmed VSCE 3.9.2 was selected from each lockfile.git diff --check.The draft package runs will exercise the Windows
vsce-sign.exepath and hostedVSCodePublishersigning before publication.