Backoff on refresh when no changes found#8811
Open
alexr00 wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates ReviewManager’s periodic polling to use an exponential backoff when refreshes don’t detect state changes, reducing unnecessary work over time while still resetting to a minimum interval when changes are observed.
Changes:
- Introduces a backoff-based polling interval (min/max + multiplier) and applies it across poll cycles.
- Updates polling to detect “change” based on PR number / head SHA and avoids false positives by preserving the previous commit SHA in a no-op validate path.
- Adds a new test suite covering backoff behavior, focus-triggered refresh behavior, and max-interval capping.
Show a summary per file
| File | Description |
|---|---|
| src/view/reviewManager.ts | Implements polling backoff logic, adjusts focus-triggered polling behavior, and refines “no meaningful change” handling to stabilize change detection. |
| src/test/view/reviewManager.test.ts | Adds unit tests validating backoff growth/reset, focus-triggered polling behavior, and maximum interval cap. |
Copilot's findings
- Files reviewed: 2/2 changed files
- Comments generated: 3
dbaeumer
previously approved these changes
Jun 25, 2026
auto-merge was automatically disabled
June 26, 2026 12:58
Pull request was converted to draft
lramos15
approved these changes
Jun 26, 2026
| if (!this._validateStatusInProgress) { | ||
| const shouldRefreshForActivePr = !!this._folderRepoManager.activePullRequest && await this.hasNewPullRequests(); | ||
| if (shouldRefreshForActivePr) { | ||
| Logger.appendLine('Polling detected potential new PR activity while a PR is active. Refreshing state.', this.id); |
| assert.ok(setTimeoutSpy.callCount > callsBeforeSkip, 'focus should cause one-off refresh and schedule next poll'); | ||
| }); | ||
|
|
||
| it('polling refreshes state when active PR exists and new PR activity is detected', async function () { |
|
|
||
| clock.tick(POLL_MIN_INTERVAL_MS * 4); | ||
| await flushMicrotasks(); | ||
| assert.strictEqual(latestScheduledDelay(), POLL_MIN_INTERVAL_MS * 6); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.