Stabilize interpreter selection integration tests by asserting on interpreter path, not envId#1571
Open
Copilot wants to merge 3 commits into
Open
Stabilize interpreter selection integration tests by asserting on interpreter path, not envId#1571Copilot wants to merge 3 commits into
Copilot wants to merge 3 commits into
Conversation
Copilot
AI
changed the title
[WIP] Fix integration test for environment persistence
Stabilize interpreter selection integration tests by asserting on interpreter path, not envId
Jun 9, 2026
edvilme
approved these changes
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
interpreterSelection.integration.test.tswas asserting equality onenvId.idacrosssetEnvironment → getEnvironmentflows. That ID is intentionally non-stable after persistence (manager may re-register with a suffixed opaque ID), which caused CI failures despite selecting the same interpreter.Root cause
envId.idas a stable identity across persistence round-trips.environmentPath.fsPath).Changes in this PR
envId.idequality assertions withenvironmentPath.fsPathequality in all affected integration tests:setEnvironment persists selectionProject selection is independent of global(global + project assertions)Change event includes old and new valuesFile inherits project environmentSetting same environment is idempotentScope
src/test/integration/interpreterSelection.integration.test.ts.