fix leak + better logic for hidden tool calls#302294
Draft
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a leaked disposable in the chat thinking/tool rendering pipeline (Issue #302066) and refines the “HiddenAfterComplete” behavior so tool invocations with user-visible output aren’t incorrectly hidden, with added regression tests.
Changes:
- Centralize “hide vs keep visible after completion” logic for
HiddenAfterCompletetool invocations. - Improve disposable registration for tool items associated with a
toolCallIdinChatThinkingContentPart. - Add tests covering
HiddenAfterCompletevisibility and title refresh behavior when tools complete.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/vs/workbench/contrib/chat/test/browser/widget/chatContentParts/chatThinkingContentPart.test.ts | Adds tests for HiddenAfterComplete completion behavior and title refresh in the thinking container. |
| src/vs/workbench/contrib/chat/browser/widget/chatContentParts/toolInvocationParts/chatToolInvocationVisibility.ts | New shared helper to decide whether tool invocations should be hidden/kept visible after completion. |
| src/vs/workbench/contrib/chat/browser/widget/chatContentParts/toolInvocationParts/chatToolInvocationPart.ts | Switches tool part rendering to use the centralized hide-after-complete helper. |
| src/vs/workbench/contrib/chat/browser/widget/chatContentParts/chatThinkingContentPart.ts | Refactors disposable registration and ensures titles refresh when tool entries are removed. |
You can also share your feedback on Copilot code review. Take the survey.
| if (isToolResultOutputDetails(resultDetails) || isToolResultInputOutputDetails(resultDetails)) { | ||
| return true; | ||
| } | ||
|
|
Comment on lines
1103
to
1108
| if (this.isExpanded() || this.hasExpandedOnce || (this.fixedScrollingMode && !this.streamingCompleted)) { | ||
| const result = factory(); | ||
| this.appendItemToDOM(result.domNode, toolInvocationId, toolInvocationOrMarkdown, originalParent); | ||
| if (result.disposable) { | ||
| const toolCallId = toolInvocationOrMarkdown && (toolInvocationOrMarkdown.kind === 'toolInvocation' || toolInvocationOrMarkdown.kind === 'toolInvocationSerialized') ? toolInvocationOrMarkdown.toolCallId : undefined; | ||
| if (toolCallId) { | ||
| this.toolDisposables.get(toolCallId)?.add(result.disposable); | ||
| } else { | ||
| this._register(result.disposable); | ||
| } | ||
| this.registerToolDisposable(result.disposable, toolInvocationOrMarkdown); | ||
| } |
Comment on lines
+76
to
+84
| function createMockToolInvocation(options?: { | ||
| toolCallId?: string; | ||
| toolId?: string; | ||
| invocationMessage?: string; | ||
| presentation?: ToolInvocationPresentation; | ||
| isAttachedToThinking?: boolean; | ||
| resultDetails?: unknown; | ||
| confirmationMessages?: unknown; | ||
| }) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #302066 and some tests + better hiding logic.