Skip to content

Remove old setting to toggle the mermaid markdown tool#316723

Open
mjbvz wants to merge 1 commit into
mainfrom
dev/mjbvz/above-muskox
Open

Remove old setting to toggle the mermaid markdown tool#316723
mjbvz wants to merge 1 commit into
mainfrom
dev/mjbvz/above-muskox

Conversation

@mjbvz
Copy link
Copy Markdown
Collaborator

@mjbvz mjbvz commented May 15, 2026

Instead you can now disable the tool itself, which is more consistent with the rest of our UX

Non-local session can use mermaid fenced code blocks

Instead you can now disable the tool itself, which is more consistent with the rest of our UX
Copilot AI review requested due to automatic review settings May 15, 2026 23:23
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the legacy mermaid-markdown.enabled setting that previously gated the Mermaid chat rendering tool, and instead restricts the contributed Mermaid tool to local chat sessions via a when clause—aligning with the direction of disabling tools directly rather than via separate feature settings.

Changes:

  • Removed the mermaid-markdown.enabled configuration property from the extension manifest.
  • Removed the associated localized description string.
  • Updated the Mermaid language model tool contribution to be enabled only when chatSessionType == local.
Show a summary per file
File Description
extensions/mermaid-markdown-features/package.nls.json Removes the localization entry for the deleted mermaid-markdown.enabled setting description.
extensions/mermaid-markdown-features/package.json Deletes the legacy setting and updates the Mermaid tool’s when clause to only apply to local chat sessions.

Copilot's findings

  • Files reviewed: 2/2 changed files
  • Comments generated: 1

Comment on lines 78 to 83
"configuration": {
"title": "%config.title%",
"properties": {
"mermaid-markdown.enabled": {
"type": "boolean",
"default": true,
"description": "%config.enabled.description%",
"scope": "application"
},
"markdown-mermaid.lightModeTheme": {
"order": 0,
"type": "string",
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants