Remove old setting to toggle the mermaid markdown tool#316723
Open
mjbvz wants to merge 1 commit into
Open
Conversation
Instead you can now disable the tool itself, which is more consistent with the rest of our UX
TylerLeonhardt
approved these changes
May 15, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the legacy mermaid-markdown.enabled setting that previously gated the Mermaid chat rendering tool, and instead restricts the contributed Mermaid tool to local chat sessions via a when clause—aligning with the direction of disabling tools directly rather than via separate feature settings.
Changes:
- Removed the
mermaid-markdown.enabledconfiguration property from the extension manifest. - Removed the associated localized description string.
- Updated the Mermaid language model tool contribution to be enabled only when
chatSessionType == local.
Show a summary per file
| File | Description |
|---|---|
| extensions/mermaid-markdown-features/package.nls.json | Removes the localization entry for the deleted mermaid-markdown.enabled setting description. |
| extensions/mermaid-markdown-features/package.json | Deletes the legacy setting and updates the Mermaid tool’s when clause to only apply to local chat sessions. |
Copilot's findings
- Files reviewed: 2/2 changed files
- Comments generated: 1
Comment on lines
78
to
83
| "configuration": { | ||
| "title": "%config.title%", | ||
| "properties": { | ||
| "mermaid-markdown.enabled": { | ||
| "type": "boolean", | ||
| "default": true, | ||
| "description": "%config.enabled.description%", | ||
| "scope": "application" | ||
| }, | ||
| "markdown-mermaid.lightModeTheme": { | ||
| "order": 0, | ||
| "type": "string", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead you can now disable the tool itself, which is more consistent with the rest of our UX
Non-local session can use mermaid fenced code blocks