Use PNG for Add Element to Chat screenshots#316807
Draft
jruales wants to merge 1 commit into
Draft
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request updates Integrated Browser “Add Element to Chat” screenshots to use PNG output, and extends the BrowserView screenshot capture API to support selecting the output image format.
Changes:
- Add
format?: 'jpeg' | 'png'toIBrowserViewCaptureScreenshotOptions(with updated docs forqualitybehavior). - Update Electron main-process screenshot capture to encode as PNG when requested.
- Switch “Add Element to Chat” element screenshots to request PNG output.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/contrib/browserView/electron-browser/features/browserEditorChatFeatures.ts | Requests PNG screenshots when attaching selected elements to chat. |
| src/vs/platform/browserView/electron-main/browserView.ts | Encodes captured screenshots as PNG when options.format === 'png', otherwise JPEG. |
| src/vs/platform/browserView/common/browserView.ts | Extends screenshot capture options with format and clarifies quality applicability/default. |
Copilot's findings
- Files reviewed: 3/3 changed files
- Comments generated: 0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.