Add chat markdown plain text fast path#316808
Draft
roblourens wants to merge 3 commits into
Draft
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a fast path to ChatContentMarkdownRenderer.render that bypasses marked and the sanitizer when the input has no markdown-significant syntax, producing the same <div class="rendered-markdown"><p>…</p></div> shape directly.
Changes:
- New
renderPlainTextMarkdownhelper that returns a rendered-markdown element when the value matches none of three exclusion regexes (inline syntax chars, GFM autolinks, block-level syntax). render()short-circuits to the fast path when applicable; otherwise falls back to the existing pipeline.- Two new unit tests cover the fast path's DOM shape and target-element reuse.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/contrib/chat/browser/widget/chatContentMarkdownRenderer.ts | Adds plain-text fast path with regex guards and a target-truncation step. |
| src/vs/workbench/contrib/chat/test/browser/widget/chatMarkdownRenderer.test.ts | Adds tests verifying fast-path DOM shape and target reuse. |
Copilot's findings
- Files reviewed: 2/2 changed files
- Comments generated: 1
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…actical-to-have-a-route-5fa025ed # Conflicts: # src/vs/workbench/contrib/chat/browser/widget/chatContentMarkdownRenderer.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Validation: