Skip to content

Fix remote agent change editor labels#316812

Draft
roblourens wants to merge 1 commit into
mainfrom
agents/vsckb-plan-so-i-open-a-file-like-b6dc2a1c
Draft

Fix remote agent change editor labels#316812
roblourens wants to merge 1 commit into
mainfrom
agents/vsckb-plan-so-i-open-a-file-like-b6dc2a1c

Conversation

@roblourens
Copy link
Copy Markdown
Member

Fixes remote Agent Host changed-file editor titles leaking packed backing URIs.

This updates the Agents Changes view to derive editor labels/descriptions from the user-facing change URI while preserving the actual content resources used for deletion, diff, and file opens.

Validation:

  • npm run compile-check-ts-native
  • npm run gulp compile
  • ./scripts/test.sh --run src/vs/sessions/contrib/changes/test/browser/changesEditorLabels.test.ts --run src/vs/workbench/services/label/test/browser/label.test.ts --grep "ChangesEditorLabels|agent host formatter labels wrapped remote file URIs"
  • npm run valid-layers-check
  • npm run precommit
  • Live Agents window verification with Playwright/CDP and dap-cli

Copilot AI review requested due to automatic review settings May 16, 2026 23:07
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses Agents Changes editor labels so remote agent-host resources display user-facing file paths instead of packed backing URIs.

Changes:

  • Adds a shared getChangesEditorLabels helper for label/description derivation.
  • Applies label overrides when opening single-file or diff editors from the Changes view.
  • Adds coverage for agent-host URI label formatting and Changes editor label derivation.
Show a summary per file
File Description
src/vs/sessions/contrib/changes/browser/changesEditorLabels.ts Adds helper to derive editor label and description from a display URI.
src/vs/sessions/contrib/changes/browser/changesView.ts Uses derived labels when opening deletion, diff, and modified-file editors.
src/vs/sessions/contrib/changes/test/browser/changesEditorLabels.test.ts Tests display URI labels versus backing URI labels.
src/vs/workbench/services/label/test/browser/label.test.ts Adds agent-host formatter coverage for wrapped remote file URIs.

Copilot's findings

  • Files reviewed: 4/4 changed files
  • Comments generated: 1

Comment thread src/vs/sessions/contrib/changes/browser/changesView.ts
@roblourens roblourens force-pushed the agents/vsckb-plan-so-i-open-a-file-like-b6dc2a1c branch 4 times, most recently from 6b41140 to 509b0db Compare May 17, 2026 00:04
Derive Changes view editor labels from the user-facing change URI so wrapped before-content resources such as git-blob snapshots do not leak into modal editor titles.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@roblourens roblourens force-pushed the agents/vsckb-plan-so-i-open-a-file-like-b6dc2a1c branch from 509b0db to 3ff69ea Compare May 17, 2026 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants