Fix remote agent change editor labels#316812
Draft
roblourens wants to merge 1 commit into
Draft
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses Agents Changes editor labels so remote agent-host resources display user-facing file paths instead of packed backing URIs.
Changes:
- Adds a shared
getChangesEditorLabelshelper for label/description derivation. - Applies label overrides when opening single-file or diff editors from the Changes view.
- Adds coverage for agent-host URI label formatting and Changes editor label derivation.
Show a summary per file
| File | Description |
|---|---|
src/vs/sessions/contrib/changes/browser/changesEditorLabels.ts |
Adds helper to derive editor label and description from a display URI. |
src/vs/sessions/contrib/changes/browser/changesView.ts |
Uses derived labels when opening deletion, diff, and modified-file editors. |
src/vs/sessions/contrib/changes/test/browser/changesEditorLabels.test.ts |
Tests display URI labels versus backing URI labels. |
src/vs/workbench/services/label/test/browser/label.test.ts |
Adds agent-host formatter coverage for wrapped remote file URIs. |
Copilot's findings
- Files reviewed: 4/4 changed files
- Comments generated: 1
6b41140 to
509b0db
Compare
Derive Changes view editor labels from the user-facing change URI so wrapped before-content resources such as git-blob snapshots do not leak into modal editor titles. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
509b0db to
3ff69ea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes remote Agent Host changed-file editor titles leaking packed backing URIs.
This updates the Agents Changes view to derive editor labels/descriptions from the user-facing change URI while preserving the actual content resources used for deletion, diff, and file opens.
Validation: