chat: Cache generated built-in agent files - #329689
Draft
roblourens (roblourens) wants to merge 2 commits into
Draft
chat: Cache generated built-in agent files#329689roblourens (roblourens) wants to merge 2 commits into
roblourens (roblourens) wants to merge 2 commits into
Conversation
Coalesce identical Plan, Ask, and Explore agent file writes so repeated provider refreshes cannot backlog large buffers. (Written by Copilot) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds idempotent caching for generated built-in agent files to avoid redundant writes.
Changes:
- Introduces a shared content-keyed file writer.
- Migrates Plan, Ask, and Explore providers.
- Adds deduplication coverage; failure-retry coverage remains needed.
Show a summary per file
| File | Description |
|---|---|
cachedAgentFileWriter.ts |
Implements cached writes and failure eviction. |
cachedAgentFileWriter.spec.ts |
Tests successful write deduplication. |
planAgentProvider.ts |
Uses the cached writer for Plan. |
askAgentProvider.ts |
Uses the cached writer for Ask. |
exploreAgentProvider.ts |
Uses the cached writer for Explore. |
Review details
- Files reviewed: 5/5 changed files
- Comments generated: 1
- Review effort level: Balanced
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
Custom-agent discovery can run repeatedly as workspace/session context changes. These providers regenerated identical content but rewrote their cache files on every call. In the Agents window, repeated session switching could therefore enqueue many identical writes and retain their buffers behind the serialized file-write queue.
This keeps provider discovery dynamic while making the generated-file I/O idempotent.
Validation
(Written by Copilot)