agentHost: Classify cancelled model call telemetry - #329695
Open
Aaron Munger (amunger) wants to merge 3 commits into
Open
agentHost: Classify cancelled model call telemetry#329695Aaron Munger (amunger) wants to merge 3 commits into
Aaron Munger (amunger) wants to merge 3 commits into
Conversation
Declare the Copilot runtime model_call_cancelled event in the generic GitHub telemetry forwarder and cover forwarding with a focused unit test. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds the GDPR contract and forwarding coverage for cancelled Copilot CLI model-call attempts.
Changes:
- Classifies cancellation properties, measurements, repository context, and correlation fields.
- Adds a focused forwarding unit test.
Show a summary per file
| File | Description |
|---|---|
copilotGitHubTelemetryForwarder.ts |
Declares cancellation telemetry classifications. |
copilotGitHubTelemetryForwarder.test.ts |
Verifies cancellation event forwarding. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Balanced
The generic forwarder behavior is already covered; this PR only needs the GDPR declaration for the new runtime event. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Remove the remaining whitespace-only diff after dropping the redundant test. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Aaron Munger (amunger)
marked this pull request as ready for review
August 7, 2026 22:18
Aaron Munger (amunger)
enabled auto-merge (squash)
August 7, 2026 22:27
Raymond Zhao (rzhao271)
approved these changes
Aug 7, 2026
Aaron Munger (amunger)
disabled auto-merge
August 7, 2026 22:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Declare the SDK-forwarded
copilotCli/model_call_cancelledevent in the Agent Host telemetry forwarder.The declaration includes:
No Agent Host turn behavior or public protocol surface changes.
Why
Part of microsoft/vscode-internalbacklog#8247.
The paired runtime change, github/copilot-agent-runtime#15211, adds per-physical-attempt
model_call_cancelledtelemetry. The generic SDK callback already forwards runtime telemetry into Microsoft telemetry; this change supplies the required GDPR contract.Existing
agentHost.turnCompleted(result=cancelled)remains the cross-provider turn-cancellation signal. This event instead completes the Copilot runtime model-attempt success/error/cancelled denominator.Data parity
response.cancelledcopilotCli/model_call_cancelledresponse.cancelledwas not a turn eventagentHost.turnCompleted(result=cancelled)Query and row implications
copilotCli/response.success,copilotCli/response.error, andcopilotCli/model_call_cancelled.agentHost.turnCompleted(result=cancelled)must remain a separate per-turn metric.Semantic shifts
Targeted ESLint passes.