Skip to content

Agent host: assess review comments before assisted approval - #329707

Draft
Benjamin Christopher Simmonds (benibenj) wants to merge 1 commit into
benibenj/agents/investigate-comments-reveal-issuefrom
benibenj/agents/assisted-review-comment-approvals
Draft

Agent host: assess review comments before assisted approval#329707
Benjamin Christopher Simmonds (benibenj) wants to merge 1 commit into
benibenj/agents/investigate-comments-reveal-issuefrom
benibenj/agents/assisted-review-comment-approvals

Conversation

@benibenj

Copy link
Copy Markdown
Contributor

Summary

  • supplement Copilot's existing assisted-approval judge with the exact untrusted PR and code-review comments
  • require both the SDK policy and the comment-specific safety assessment to permit automatic submission
  • bind assisted approval to a fingerprint of the reviewed comments so changed comments are reassessed
  • fall back to the existing interactive picker on unsafe, unavailable, invalid, oversized, or timed-out assessments
  • surface assisted-approval reasons through the existing risk-assessment UI

Stack

Testing

  • Reviewed twice with the Opus 5 rubber-duck reviewer and addressed its findings.
  • Final validation has not been rerun after the last review fixes.

Supplement the existing assisted approval judge with a state-bound assessment of untrusted PR and code-review comments. Unsafe or failed assessments remain interactive while safe approvals submit only the exact reviewed snapshot.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant