sessions: support editor tab display modes - #329783
Merged
Sandeep Somavarapu (sandy081) merged 2 commits intoAug 9, 2026
Merged
sessions: support editor tab display modes#329783Sandeep Somavarapu (sandy081) merged 2 commits into
Sandeep Somavarapu (sandy081) merged 2 commits into
Conversation
Sandeep Somavarapu (sandy081)
enabled auto-merge (squash)
August 8, 2026 21:28
Copilot started reviewing on behalf of
Sandeep Somavarapu (sandy081)
August 8, 2026 21:28
View session
Contributor
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: Benjamin Christopher Simmonds (@benibenj)Matched files:
|
Fixes #329781 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds configurable single/multiple editor-tab modes to the Agents window while preserving its dedicated header and Add Tab behavior.
Changes:
- Applies tab-mode overrides based on configuration and pane visibility.
- Moves breadcrumbs into the Agents header and supports Add Tab in single-title mode.
- Adds context keys, styling, documentation, fixtures, and tests.
Show a summary per file
| File | Description |
|---|---|
.github/skills/sessions/SKILL.md |
Documents tab-mode conventions. |
src/vs/sessions/LAYOUT.md |
Documents updated layout behavior. |
src/vs/sessions/browser/parts/singlePaneEditorPart.ts |
Selects the effective tab mode. |
src/vs/sessions/common/contextkeys.ts |
Adds managed-tab availability keys. |
src/vs/sessions/contrib/editor/browser/addTabActions.ts |
Expands single-mode Add Tab entries. |
src/vs/sessions/contrib/editor/browser/media/editorHeader.css |
Styles separate header rows. |
src/vs/sessions/contrib/editor/browser/media/editorTabs.css |
Styles single titles and Add Tab. |
src/vs/sessions/contrib/editor/test/browser/editor.contribution.test.ts |
Adds Add Tab condition coverage. |
src/vs/sessions/contrib/editor/test/browser/editorHeader.fixture.ts |
Adds a single-tab visual fixture. |
src/vs/sessions/contrib/layout/browser/singlePane/singlePaneManagedTabsStrategy.ts |
Maintains availability context keys. |
src/vs/sessions/contrib/layout/test/browser/desktopSessionLayoutController.test.ts |
Tests availability state. |
src/vs/sessions/test/browser/workbench.test.ts |
Tests tab override selection. |
src/vs/workbench/browser/parts/editor/editorHeaderControl.ts |
Hosts breadcrumbs when a header exists. |
src/vs/workbench/browser/parts/editor/editorTabsControl.ts |
Shares Add Tab toolbar support. |
src/vs/workbench/browser/parts/editor/editorTitleControl.ts |
Propagates header ownership. |
src/vs/workbench/browser/parts/editor/multiEditorTabsControl.ts |
Uses shared Add Tab handling. |
src/vs/workbench/browser/parts/editor/multiRowEditorTabsControl.ts |
Propagates header configuration. |
src/vs/workbench/browser/parts/editor/singleEditorTabsControl.ts |
Supports header breadcrumbs and Add Tab. |
Review details
Tip
Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 18/18 changed files
- Comments generated: 1
- Review effort level: Balanced
Sandeep Somavarapu (sandy081)
force-pushed
the
sandy081/agents/single-sidepane-editor-tab-support
branch
from
August 8, 2026 21:32
c4505d8 to
d16548f
Compare
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
Screenshot ChangesBase: Added (2)
|
roblourens (roblourens)
approved these changes
Aug 9, 2026
Sandeep Somavarapu (sandy081)
deleted the
sandy081/agents/single-sidepane-editor-tab-support
branch
August 9, 2026 07:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
workbench.editor.showTabsvaluessingleandmultiplein the Agents window single-pane layout.nonetosingle.Why
The single-pane layout previously forced multiple tabs. Simply removing that override exposed layout and discoverability issues in single-tab mode, including duplicated path presentation, misplaced header actions, and unavailable Add Tab entries.
Validation
npm run compileandnpm run hygienepassed before rebasing onto currentmain.anyerrors insrc/vs/workbench/services/assignment/common/assignmentService.ts:432.Fixes #329781