fix: guard ConfigureDbContext() Migrate() with IHistoryRepository (Galera-safe)#1412
Merged
Conversation
Avoids DDL on every API pod restart when plugin schemas are current (Galera-safe). Falls back to Migrate() on fresh install or when migrations are pending. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR updates the Workflow plugin startup database initialization to avoid running EF Core migrations (and the associated DDL/locks) on every API pod restart by guarding Database.Migrate() with an IHistoryRepository.Exists() check plus a pending-migrations check.
Changes:
- Added EF Core infrastructure/migrations dependencies to access
IHistoryRepository. - Wrapped
context.Database.Migrate()behind!historyRepo.Exists() || context.Database.GetPendingMigrations().Any()to only migrate on fresh installs or when migrations are pending.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
154
to
+158
| var contextFactory = new WorkflowPnContextFactory(); | ||
| var context = contextFactory.CreateDbContext(new[] { connectionString }); | ||
| context.Database.Migrate(); | ||
| var historyRepo = context.GetService<IHistoryRepository>(); | ||
| if (!historyRepo.Exists() || context.Database.GetPendingMigrations().Any()) | ||
| { |
The eform-angular-frontend checkout in CI does not have these directories pre-created, causing cp to fail. Add mkdir -p to ensure they exist. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
LoginConstants.ts was removed from eform-angular-frontend stable but is still imported by cypress/e2e/Login.page.ts. Vendor it in the plugin repo and copy it into the frontend checkout in CI. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…adlessplugin - workflow-playwright-test: mkdir e2e/Constants + copy LoginConstants.ts so cypress DB config test resolves the import - workflow-test: replace missing testheadlessplugin npm script with a skip message (wdio plugin tests were migrated to workflow-playwright-test) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Database.Migrate()inConfigureDbContext()with anIHistoryRepository.Exists()guard to eliminate unnecessary DDL on every API pod restartWhy
On a MariaDB 11.4 Galera cluster with ~250 tenants,
Database.Migrate()issues DDL (CREATE TABLE IF NOT EXISTS __EFMigrationsHistory,GET_LOCK) on every app restart even when the schema is already current. With multiple pods per tenant this causes cluster-wide desync/resync on every rolling update.The guard pattern:
IHistoryRepository.Exists()— safeinformation_schemaread, returns false if history table is absentGetPendingMigrations().Any()— only called when the table existsDatabase.Migrate()— called only when needed: fresh install, or pending migrationsIn production (schema current): no DDL, no
GET_LOCK. On fresh plugin activation: falls through and creates the schema.Test Plan
🤖 Generated with Claude Code