Add custom-repeat day & week scheduling e2e tests (#898)#918
Merged
Conversation
r/calendar-custom-repeat-day-week.spec.ts asserts occurrences render on the
correct day columns (not just the collapsed label) for the Tilpasset… dialog:
- CR01 daily, CR02 everyNd (step=2)
- CR03/CR04 0-weekday quirk -> everyNWeekAll (all 7 days), incl every-2nd-week
- CR05/CR06 weeklyOne / everyNWeekOne (Monday)
- CR07 weeklyMulti (Mon/Wed/Fri), CR09 all-7-days ("Weekly on all days")
CR08 already covered by I1. Distinct Monday hours per test avoid daily/all-day
occurrences intercepting later empty-slot clicks.
Refs #898.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Adds a new Playwright E2E regression suite to validate the calendar “Tilpasset…” (custom repeat) dialog for day- and week-based recurrence, asserting that generated .task-block occurrences render in the correct day-of-week columns across weeks, per issue #898.
Changes:
- Introduces
calendar-custom-repeat-day-week.spec.tscovering custom repeat matrix rows CR01–CR07 and CR09 (CR08 referenced as already covered elsewhere). - Implements shared helper functions for custom-repeat dialog interaction (unit/step/weekday toggles) and for asserting presence/absence by day column.
- Adds serial seeding/cleanup flow (property + worker) consistent with other calendar E2E suites in this repo.
Comment on lines
+352
to
+359
| // Seed week: Mon (0), Wed (2), Fri (4), Sun (6) present; Tue (1), Thu (3) absent. | ||
| await expectPresent(calendarPage, 0, title, 'the seed week'); | ||
| await expectAbsent(calendarPage, 1, title, 'the seed week'); | ||
| await expectPresent(calendarPage, 2, title, 'the seed week'); | ||
| await expectAbsent(calendarPage, 3, title, 'the seed week'); | ||
| await expectPresent(calendarPage, 4, title, 'the seed week'); | ||
| await expectPresent(calendarPage, 6, title, 'the seed week'); | ||
| }); |
…eekday-only (#898) CI showed the 0-weekday custom-week case does not render all 7 days: the frontend builds kind=everyNWeekAll but the wire payload (repeatType=2, repeatWeekdaysCsv=null) is rendered by GetOccurrencesInWeek as start-weekday- only (Monday). Documented as a frontend/backend discrepancy; lets the standard CR05-CR09 (weeklyOne/weeklyMulti) run. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #898 — Tilpasset… (custom repeat) day & week occurrence scheduling, asserting blocks render on the right day columns across weeks: CR01 daily, CR02 everyNd, CR03/CR04 the 0-weekday→everyNWeekAll quirk (all 7 days), CR05/CR06 weeklyOne/everyNWeekOne, CR07 weeklyMulti, CR09 all-7-days. CR08 already covered by I1. New spec r/calendar-custom-repeat-day-week.spec.ts.
🤖 Generated with Claude Code