fix: guard SqlController Migrate() with IHistoryRepository.Exists()#4664
Merged
Conversation
Prevents crash on fresh install if __EFMigrationsHistory is absent. In production (schema current): Exists()=true, GetPendingMigrations()=empty, Migrate() is never called — no DDL, Galera-safe. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
IHistoryRepository.Exists()guard aroundDatabase.Migrate()inSqlControllerso DDL is only issued when actually needed.Why
The existing
GetPendingMigrations().Any()guard throws (and re-throws) if__EFMigrationsHistorydoesn't exist yet, crashing startup on a fresh SDK DB. With theIHistoryRepository.Exists()outer guard:Exists()= false → falls through toMigrate()→ creates schema ✅Exists()= true,GetPendingMigrations()= empty → skips entirely, no DDL, no GET_LOCK ✅Exists()= true, pending found →Migrate()applies them ✅On a Galera cluster with ~250 tenants, this eliminates SDK DDL from every pod restart.
Test Plan
🤖 Generated with Claude Code