Fix write-unsafe VFS refresh when loading templates#2593
Closed
morfidon wants to merge 1 commit intominecraft-dev:devfrom
Closed
Fix write-unsafe VFS refresh when loading templates#2593morfidon wants to merge 1 commit intominecraft-dev:devfrom
morfidon wants to merge 1 commit intominecraft-dev:devfrom
Conversation
Replace RefreshQueue.refresh() wrapped in writeAction with VirtualFile.refresh() invoked via Application.invokeAndWait(..., modalityState). This preserves the current wizard/dialog modality state and avoids Write-unsafe context! failures on newer IntelliJ Platform builds.
Member
|
Thanks for the contribution, I appreciate the time and effort. Unfortunately this doesn't fix the problem, which I have tried before. You'll find the I believe I have a working fix, though it's a little hacky. I haven't had a ton of time lately, but when I can I will try to revisit this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #2592
Run VFS refresh via Application.invokeAndWait(..., modalityState) instead of calling RefreshQueue.refresh() inside a writeAction.
This preserves the current wizard/dialog modality state and prevents "Write-unsafe context! Model changes are allowed from write-safe contexts only"errors when loading templates on newer IntelliJ Platform versions.