fix(connect): log exception message when rejecting session proposals - #148
Open
minekube-ai-engineer[bot] wants to merge 1 commit into
Open
fix(connect): log exception message when rejecting session proposals#148minekube-ai-engineer[bot] wants to merge 1 commit into
minekube-ai-engineer[bot] wants to merge 1 commit into
Conversation
Since 0.15.1 the proposal-rejection WARN logged only the exception class name and discarded e.getMessage(), so every rejection looked identical (category=IllegalStateException) and the actual failing check was invisible (connect-java#144). Log the message at WARN level and the full throwable at DEBUG. Regression test asserts the WARN carries the exception message for the stage() ISE path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Source: Discord ask-support thread — the exact thread the report came from.
Problem
Since 0.15.1,
WatcherRegister.onProposal's rejection catch logs only the exception class name and discardse.getMessage():Every rejected proposal therefore looks identical and the failing check is invisible — the reason #144 ("session proposals rejected with IllegalStateException") was never root-caused. This is the diagnosability defect blocking #144 and the fresh escalation from byteadri.exe (fails identically on stable Velocity 3.4.0 and 4.1.0-SNAPSHOT, so #144's SNAPSHOT-only assumption is disproven).
Change
message={}(the exception message) alongsidecategory={}— one log line identifies the failing check.rejectedProposalWarnCarriesTheExceptionMessagedrives the real mechanism (BedrockAdmissionCoordinator.stage()→ ISE "Bedrock admission has expired or been superseded") and asserts the WARN carries the message. RED on unfixed code (message absent), GREEN after.TDD evidence
WARN must carry the exception message, got: [Rejected one Connect session proposal (category=IllegalStateException); keeping WatchService active] ==> expected: <true> but was: <false>:core:testWatcherRegisterTest 24/24; full./gradlew check342/342 (velocity + core; one pre-existing environmentalReleaseAssetVerificationTestfailure withoutjqon PATH passes with it — unrelated).Once this ships, the user's next failed join prints the actual check that failed, which is the root cause for #144 and this escalation.