sdk-files: Add internal error handling to SDK installer#638
Open
Seongook-CHOI-ML wants to merge 3 commits into
Open
sdk-files: Add internal error handling to SDK installer#638Seongook-CHOI-ML wants to merge 3 commits into
Seongook-CHOI-ML wants to merge 3 commits into
Conversation
Add error check of sed command for updating gcc-sysroot-wrapper.sh. Signed-off-by: SeongOok CHOI <seongook.choi@miraclelinux.com>
Since single parenthesis run the commands inside in a subshell, the installer script didn't stop when relocate-sdk.sh was failed. Now, it is fixed by using "||" operator. Signed-off-by: SeongOok CHOI <seongook.choi@miraclelinux.com>
Modify to exit installer script when external commands. Signed-off-by: SeongOok CHOI <seongook.choi@miraclelinux.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Add internal error handling to SDK installer.
Prepare
How to test
Test result
Before fix:
After fix:
Before fix:
After fix: