feat(iocp): prefer async connect#158
Open
nikneym wants to merge 7 commits into
Open
Conversation
Contributor
Author
|
cc @Corendos I'd be glad if you could review this one too 👀 |
Corendos
reviewed
May 8, 2025
Corendos
left a comment
Corendos
left a comment
Contributor
There was a problem hiding this comment.
Left some nits, but once resolved, it's ready to merge ! 😁
On a side note, Windows keep on delivering in weirdness sometimes. What is this required dynamic loading of ConnectEx 😂
nikneym
force-pushed
the
win-async-connect
branch
from
08fa6ec to
2665f6a
Compare
Contributor
Author
|
This has been rotting for quite a while... Upstreamed it now; cc @Corendos should be fine now! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #151. API is not changed; all tests are passing as before.