Fix Linux local mode missing traffic from non-main threads#314
Open
samatar26 wants to merge 1 commit into
Open
Fix Linux local mode missing traffic from non-main threads#314samatar26 wants to merge 1 commit into
samatar26 wants to merge 1 commit into
Conversation
|
Passing-by comment: so user side 's PID is actually kernel side TGID. |
Author
|
@jackyzy823 yeah exactly - and the behaviour in Linux of mitmproxy is different from macOS and Windows so I believe it must be a bug. Mocking traffic of a python program that's making requests from multiple threads works fine on my macOS machine, but fails on a Linux based GitHub action runner |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes mitmproxy/mitmproxy#8282
ctx.pid()is the thread id, not the process id so sockets from non-mainthreads bypassed Linux local capture. Changed to
ctx.tgid(), matching macOS/Windows.