Update MITOC Main Page + Bunkhouse Banner + typo fixes#247
Open
LucasEhinger wants to merge 6 commits intomitoc:mainfrom
Open
Update MITOC Main Page + Bunkhouse Banner + typo fixes#247LucasEhinger wants to merge 6 commits intomitoc:mainfrom
LucasEhinger wants to merge 6 commits intomitoc:mainfrom
Conversation
…edia files and update caching headers. Add fallback imagage background when resolution is low or loading video background takes long time.
✅ Deploy Preview for mitoc ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NB. I'm not a web dev, so it's entirely possible that I did something stupid. Unsure if hosting such a large mp4 file will cause issues, but I did my best to make sure it ran on different platforms, and will fall back to a static image if resolution/internet speed are too low. Hosting video on youtube (https://www.youtube.com/watch?v=kX6MQnqms_k) worked locally, but failed on netlify builds, so I gave up and just uploaded entire mp4 video to github.
If I did something dumb, please reject/modify as needed!
Solicited and incorporated feedback from MITOC leaders via slack on formatting and language. People were broadly in favor of this change.