fix: handle empty power history in CPU.total_power() (#832)#1127
Open
agodianel wants to merge 1 commit intomlco2:masterfrom
Open
fix: handle empty power history in CPU.total_power() (#832)#1127agodianel wants to merge 1 commit intomlco2:masterfrom
agodianel wants to merge 1 commit intomlco2:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a
ZeroDivisionErrorcrash that occurs in the total_power method when the system fails to collect any power samples (resulting in an empty power history).The previous code checked whether the power history length was 0 immediately after an append call, meaning the condition was a dead code path and never caught the empty list. This has been updated to check for an empty list of watts immediately before the division step, safely returning 0 W instead of crashing.
Related Issue
Fixes #832
Motivation and Context
Prevents CodeCarbon from crashing entirely when hardware sensors (like Intel RAPL or Power Gadget) occasionally fail to return valid readings during a sampling interval.
How Has This Been Tested?
ZeroDivisionError.Types of changes
What types of changes does your code introduce? Put an
xin all the boxes that apply: