Skip to content

test: add device orientation tests #308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gmegidish wants to merge 1 commit into
base: main
Choose a base branch
from
Open

test: add device orientation tests #308

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
71 changes: 71 additions & 0 deletions test/simulator.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,6 +261,48 @@ test.describe('iOS Simulator Tests', () => {
verifyRawViewtreeDump(rawDump);
});

test('should rotate the playground app between portrait and landscape', async () => {
test.skip(!simulatorId, 'simulator not found');

// starting the device agent dismisses whatever is in the foreground,
// so warm it up before launching the app under test
dumpUI(simulatorId);

// relaunch so the app starts at its root menu instead of a previously visited screen
terminateApp(simulatorId, 'com.mobilenext.playground');
await new Promise(resolve => setTimeout(resolve, 2000));
launchApp(simulatorId, 'com.mobilenext.playground');
await new Promise(resolve => setTimeout(resolve, 5000));

tapElementByName(simulatorId, 'Basic UI');
await new Promise(resolve => setTimeout(resolve, 3000));
verifyElementExists(dumpUI(simulatorId), 'Reset Counter');

expect(getOrientation(simulatorId)).toBe('portrait');
const portraitScreenshot = getScreenshotDimensions(simulatorId);
expect(portraitScreenshot.height).toBeGreaterThan(portraitScreenshot.width);

setOrientation(simulatorId, 'landscape');
await new Promise(resolve => setTimeout(resolve, 3000));
expect(getOrientation(simulatorId)).toBe('landscape');

// the shorter landscape viewport pushes Reset Counter below the fold,
// while Text Input stays visible at the top of the form
const landscapeDump = dumpUI(simulatorId);
verifyElementDoesNotExist(landscapeDump, 'Reset Counter');
verifyElementExists(landscapeDump, 'Text Input');

const landscapeScreenshot = getScreenshotDimensions(simulatorId);
expect(landscapeScreenshot.width).toBeGreaterThan(landscapeScreenshot.height);

setOrientation(simulatorId, 'portrait');
await new Promise(resolve => setTimeout(resolve, 3000));
expect(getOrientation(simulatorId)).toBe('portrait');

const restoredScreenshot = getScreenshotDimensions(simulatorId);
expect(restoredScreenshot.height).toBeGreaterThan(restoredScreenshot.width);
});
Comment on lines +264 to +304

@coderabbitai coderabbitai Bot Jul 28, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

Make orientation setup and cleanup failure-safe.

The simulator can begin in landscape, causing the portrait assertions to fail before line 285. Also, any failure after rotation skips lines 298-300 and leaks landscape state into subsequent tests. Capture the original orientation, explicitly set portrait before navigating, and restore the original state in try/finally.

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@test/simulator.spec.ts` around lines 264 - 304, Update the “should rotate the
playground app between portrait and landscape” test to capture the simulator’s
original orientation, set portrait before app navigation and initial assertions,
and wrap the rotation flow in try/finally. In the finally block, restore the
captured orientation so failures cannot leave the simulator in landscape.


test.describe('fs operations on app container (com.mobilenext.playground)', () => {
const packageName = 'com.mobilenext.playground';
let containerPath: string;
Expand Down Expand Up @@ -537,6 +579,35 @@ function pressButton(simulatorId: string, button: string): void {
mobilecli(['io', 'button', button, '--device', simulatorId]);
}

function tapElementByName(simulatorId: string, name: string): void {
const element = findElementByName(dumpUI(simulatorId), name);
const centerX = element.rect.x + Math.floor(element.rect.width / 2);
const centerY = element.rect.y + Math.floor(element.rect.height / 2);
tap(simulatorId, centerX, centerY);
}

function getOrientation(simulatorId: string): string {
const response = mobilecli(['device', 'orientation', 'get', '--device', simulatorId]);
expect(response.status).toBe('ok');
return response.data.orientation;
}

function setOrientation(simulatorId: string, orientation: string): void {
const response = mobilecli(['device', 'orientation', 'set', orientation, '--device', simulatorId]);
expect(response.status).toBe('ok');
}

function verifyElementDoesNotExist(uiDump: UIDumpResponse, name: string): void {
const elements = uiDump?.data?.elements;

if (!elements) {
throw new Error(`No UI elements found in response. Status: ${uiDump?.status}`);
}

const element = elements.find(el => el.name === name || el.label === name);
expect(element, `Element "${name}" was expected to be off screen, but was found`).toBeUndefined();
}

function verifyElementExists(uiDump: UIDumpResponse, name: string): void {
const elements = uiDump?.data?.elements;

Expand Down
Loading