feat: add toHaveCount and toBeEmpty assertions#122
Merged
Conversation
6d91d1a to
53eb762
Compare
Member
|
@alexC2K thank you for this great addition! merging it in! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds two new locator assertions to
LocatorAssertionsinexpect.ts, matching the Playwright API surface:toHaveCount(n)- polls until the number of elements matched by a locator equalsn.toBeEmpty()- polls until a form element'svalueis an empty string.Both assertions support
.notnegation and an optional{ timeout }override, consistent with all other assertions in the file.Also added unit tests for these two assertions.
Test plan
expect(locator).toHaveCount(3)passes when count matchesexpect(locator).toHaveCount(5)throwsExpectErroron mismatch (with short timeout)expect(locator).not.toHaveCount(5)passes when count differsexpect(locator).toHaveCount(0)passes when nothing is foundexpect(locator).toBeEmpty()passes whenvalueis""expect(locator).toBeEmpty()throws when value is non-emptyexpect(locator).not.toBeEmpty()passes when value is non-empty