test: skip overlay tests when overlayfs mounts are unavailable#6799
Open
immanuwell wants to merge 1 commit into
Open
test: skip overlay tests when overlayfs mounts are unavailable#6799immanuwell wants to merge 1 commit into
immanuwell wants to merge 1 commit into
Conversation
Signed-off-by: immanuwell <pchpr.00@list.ru>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
go test ./util/...can blow up for non-root users becauseutil/overlayhard fails when overlayfs mounts are blocked.This adds a tiny one-shot probe and skips those tests when the host cant do the mount. If overlay mounts work, test behavior stays the same.
Repro
go test -v ./util/overlay -run TestSimpleDiff -count=1Before, it dies with
operation not permitted.After this patch it skips cleanly, which is way less noisy.
Related-ish: #4667 #879