Skip to content

Deprecate repo in favor of modal-labs/modal-client#292

Merged
thomasjpfan merged 17 commits into
mainfrom
thomasjpfan/deprecated-package
Mar 17, 2026
Merged

Deprecate repo in favor of modal-labs/modal-client#292
thomasjpfan merged 17 commits into
mainfrom
thomasjpfan/deprecated-package

Conversation

@thomasjpfan
Copy link
Copy Markdown
Contributor

@thomasjpfan thomasjpfan commented Mar 6, 2026

After this we can release a final go tag so users can see all the deprecation warnings.

Linters will catch this warning:

Screenshot 2026-03-09 at 1 27 40 PM

And in my IDE:

Screenshot 2026-03-09 at 1 28 16 PM

For us to migrate:

  1. Do a release of the SDKs for modal-client.
  2. Merge this PR and manually release just the GO SDK.
  3. Archive this repo.

@cursor
Copy link
Copy Markdown

cursor Bot commented Mar 6, 2026

PR Summary

Low Risk
Mostly documentation/metadata and linter-configuration updates to announce deprecation and suppress expected warnings; no runtime logic changes.

Overview
Deprecates this repo’s Go SDK in favor of github.com/modal-labs/modal-client/go, adding prominent migration guidance in the root README.md, modal-go/README.md, and a new modal-go/v0.7.3 entry in CHANGELOG.md.

Adds Go deprecation markers (Deprecated: in modal-go/doc.go and a top-level comment in modal-go/go.mod) and updates modal-go/.golangci.toml to exclude staticcheck deprecation and package comment warnings (e.g., SA1019, ST1000) in targeted paths so the final release can ship cleanly.

Written by Cursor Bugbot for commit 5b83807. This will update automatically on new commits. Configure here.

Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Comment thread modal-go/doc.go Outdated
Comment thread README.md Outdated
- **[Go](./modal-go/README.md)**
Run the following in your project: `go get github.com/modal-labs/modal-client/go@latest`

Replace all imports of `github.com/modal-labs/libmodal/modal-go` with `github.com/modal-labs/modal-client/g`.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo? Or am I missing something?

Suggested change
Replace all imports of `github.com/modal-labs/libmodal/modal-go` with `github.com/modal-labs/modal-client/g`.
Replace all imports of `github.com/modal-labs/libmodal/modal-go` with `github.com/modal-labs/modal-client/go`.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a typo. 😅

@thomasjpfan thomasjpfan enabled auto-merge (squash) March 17, 2026 17:21
@thomasjpfan thomasjpfan merged commit 9d2210b into main Mar 17, 2026
6 checks passed
@thomasjpfan thomasjpfan deleted the thomasjpfan/deprecated-package branch March 17, 2026 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants