Megatron GLM evaluation#45
Draft
pawalt wants to merge 1 commit into
Draft
Conversation
Co-authored-by: Peyton Walters <pawalt@hey.com>
|
Cursor Agent can help with this pull request. Just |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a native Megatron evaluation pipeline for GLM-4.7 LoRA checkpoints on Modal.
This PR introduces:
eval.pyscript that performs Megatron-native evaluation, incorporating critical patches to correctly load LoRA adapters from distributed checkpoints, especially for MoE models. This addresses issues encountered when evaluating LoRA models within the Megatron-Bridge framework.eval_loraModal function inmodal_train.pyto orchestrate the distributed evaluation. This function handles resolving checkpoint paths, ensures a validation dataset is available (by linking to the existing training dataset ifvalidation.jsonlis missing), and launches thetorchruncommand across the clustered Modal nodes.README.mdto document the new evaluation functionality and usage instructions.This enables users to evaluate their GLM-4.7 LoRA checkpoints on Modal using the existing LongMIT dataset, providing a crucial diagnostic tool for their training pipelines.
Checklist
latest(e.g.,nvcr.io/nvidia/nemo:25.11)python_versionfor the base image, if it is used (Implicit innemo:25.11image)~=x.y.zor==x.y(Dependencies are primarily handled by the base NeMo image)version < 1are pinned to patch version,==0.y.z(N/A, dependencies handled by base image)