[Server][Client] Bridge W3C trace context between HTTP headers and _meta (SEP-414) - #473
Open
chr-hertel wants to merge 1 commit into
Open
Conversation
…eta (SEP-414) RequestMeta::parseTraceContext() now falls back to the native traceparent/ tracestate/baggage HTTP headers when _meta carries none, and HeaderFactory mirrors an application-set _meta trace context onto those same headers on outbound requests. _meta wins when both are present.
chr-hertel
requested review from
CodeWithKyrian,
Nyholm and
soyuka
as code owners
August 22, 2026 00:18
chr-hertel
added
Server
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_meta-based trace context propagation already existed (RequestMetaparsestraceparent/tracestate/baggagefrom JSON-RPC_meta), but nothing bridged it to/from native HTTP headers — so a caller propagating trace context via HTTP headers only, with no_meta, got no trace context at all, and vice versa.src/Server/Stateless/RequestMeta.php:parseTraceContext()now falls back to the matching HTTP header when_metadoesn't set a trace key._metawins on conflict, since it's more specific to the call.src/Server/Stateless/StatelessProtocol.php: threads the request's headers through toRequestMeta::fromParams().src/Client/Stateless/HeaderFactory.php: mirrors any_metatrace context onto outboundtraceparent/tracestate/baggageHTTP headers.Closes #355.
Test plan
_meta→_metapopulated; both present (_metawins); stdio transport (no HTTP headers) still works via_metaalonephpunitsuite passes (1708 tests)phpstan analyse— no errors