fix: replay in-memory events for underscore stream ids#2044
Open
raashish1601 wants to merge 1 commit into
Open
fix: replay in-memory events for underscore stream ids#2044raashish1601 wants to merge 1 commit into
raashish1601 wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: 925825b The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #943.
Summary
InMemoryEventStore's stored event metadata instead of parsing the generated event ID_GET_stream, the standalone Streamable HTTP SSE stream ID@modelcontextprotocol/sdkThis keeps replay working for stream IDs that contain or start with underscores.
Validation
npm test -- test/integration-tests/taskResumability.test.tsnpm run typechecknpx prettier --check src/examples/shared/inMemoryEventStore.ts test/integration-tests/taskResumability.test.ts .changeset/fix-inmemory-event-store-sse-resume.mdnpm run buildcompiler steps:npx tsc -p tsconfig.prod.json --pretty falsenpx tsc -p tsconfig.cjs.json --pretty falsegit diff --checkNote:
npm run builditself uses POSIX shell syntax (mkdir -p ... && ...) and does not start under Windows PowerShell, so I ran the equivalent compiler commands directly.