Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fix-optional-arguments-prompts-tools.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@modelcontextprotocol/sdk': patch
---

Treat omitted `arguments` as an empty object when validating prompts and tools with optional argument schemas.
4 changes: 2 additions & 2 deletions src/server/mcp.ts
Original file line number Diff line number Diff line change
Expand Up @@ -271,7 +271,7 @@ export class McpServer {
// If that fails, use the schema directly (for union/intersection/etc)
const inputObj = normalizeObjectSchema(tool.inputSchema);
const schemaToParse = inputObj ?? (tool.inputSchema as AnySchema);
const parseResult = await safeParseAsync(schemaToParse, args);
const parseResult = await safeParseAsync(schemaToParse, args ?? {});
if (!parseResult.success) {
const error = 'error' in parseResult ? parseResult.error : 'Unknown error';
const errorMessage = getParseErrorMessage(error);
Expand Down Expand Up @@ -605,7 +605,7 @@ export class McpServer {

if (prompt.argsSchema) {
const argsObj = normalizeObjectSchema(prompt.argsSchema) as AnyObjectSchema;
const parseResult = await safeParseAsync(argsObj, request.params.arguments);
const parseResult = await safeParseAsync(argsObj, request.params.arguments ?? {});
if (!parseResult.success) {
const error = 'error' in parseResult ? parseResult.error : 'Unknown error';
const errorMessage = getParseErrorMessage(error);
Expand Down
107 changes: 107 additions & 0 deletions test/server/mcp.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1147,6 +1147,57 @@ describe.each(zodTestMatrix)('$zodVersionLabel', (entry: ZodMatrixEntry) => {
);
});

test('should accept omitted arguments for tools with optional args', async () => {
const mcpServer = new McpServer({
name: 'test server',
version: '1.0'
});
const client = new Client({
name: 'test client',
version: '1.0'
});

mcpServer.registerTool(
'test',
{
inputSchema: {
limit: z.number().optional(),
offset: z.number().optional()
}
},
async ({ limit, offset }) => ({
content: [
{
type: 'text',
text: `limit: ${limit ?? 'default'}, offset: ${offset ?? 'default'}`
}
]
})
);

const [clientTransport, serverTransport] = InMemoryTransport.createLinkedPair();

await Promise.all([client.connect(clientTransport), mcpServer.server.connect(serverTransport)]);

const result = await client.request(
{
method: 'tools/call',
params: {
name: 'test'
}
},
CallToolResultSchema
);

expect(result.isError).toBeUndefined();
expect(result.content).toEqual([
{
type: 'text',
text: 'limit: default, offset: default'
}
]);
});

/***
* Test: Preventing Duplicate Tool Registration
*/
Expand Down Expand Up @@ -3577,6 +3628,62 @@ describe.each(zodTestMatrix)('$zodVersionLabel', (entry: ZodMatrixEntry) => {
).rejects.toThrow(/Invalid arguments/);
});

test('should accept omitted arguments for prompts with optional args', async () => {
const mcpServer = new McpServer({
name: 'test server',
version: '1.0'
});

const client = new Client({
name: 'test client',
version: '1.0'
});

mcpServer.registerPrompt(
'test',
{
argsSchema: {
context: z.string().optional()
}
},
async ({ context }) => ({
messages: [
{
role: 'assistant',
content: {
type: 'text',
text: `context: ${context ?? 'none'}`
}
}
]
})
);

const [clientTransport, serverTransport] = InMemoryTransport.createLinkedPair();

await Promise.all([client.connect(clientTransport), mcpServer.server.connect(serverTransport)]);

const result = await client.request(
{
method: 'prompts/get',
params: {
name: 'test'
}
},
GetPromptResultSchema
);

expect(result.messages).toEqual([
{
role: 'assistant',
content: {
type: 'text',
text: 'context: none'
}
}
]);
});

/***
* Test: Preventing Duplicate Prompt Registration
*/
Expand Down
Loading