fix: clear session ID on HTTP 404 per MCP spec §Session Management#2086
Open
Christian-Sidak wants to merge 1 commit into
Open
fix: clear session ID on HTTP 404 per MCP spec §Session Management#2086Christian-Sidak wants to merge 1 commit into
Christian-Sidak wants to merge 1 commit into
Conversation
When a server returns 404 in response to a request with Mcp-Session-Id, the MCP spec (2025-03-26 §Session Management point 4) requires clearing the session ID so the next request triggers a fresh initialize handshake. Previously, both `_send()` (POST) and `_startOrAuthSse()` (GET) threw StreamableHTTPError without clearing `_sessionId`, leaving the transport stuck with a stale session ID on all subsequent calls. Fixes modelcontextprotocol#1708 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: 6a46396 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@modelcontextprotocol/client
@modelcontextprotocol/server
@modelcontextprotocol/express
@modelcontextprotocol/fastify
@modelcontextprotocol/hono
@modelcontextprotocol/node
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_sessionIdin_send()(POST path) when the server responds with HTTP 404 and a session ID was set_sessionIdin_startOrAuthSse()(GET path) with the same conditionBackground
The MCP spec (2025-03-26) §Session Management point 4 states:
Previously, both code paths threw
StreamableHTTPErrorwithout clearingthis._sessionId, leaving the transport stuck with a stale session ID on all subsequent calls. Every follow-upsend()would keep attaching the deadMcp-Session-Idheader and receiving 404 indefinitely.Test plan
should clear session ID on 404 POST (per spec §Session Management)— POST path clears_sessionIdafter 404should clear session ID on 404 GET SSE (per spec §Session Management)— GET path clears_sessionIdafter 404should NOT clear session ID on non-404 errors— 500 errors leave_sessionIdintactFixes #1708