Skip to content

Handle null sync progress text in mps-sync-plugin3#2718

Open
Copilot wants to merge 2 commits into
mainfrom
copilot/fix-synchronizing-message
Open

Handle null sync progress text in mps-sync-plugin3#2718
Copilot wants to merge 2 commits into
mainfrom
copilot/fix-synchronizing-message

Conversation

Copy link
Copy Markdown

Copilot AI commented Jun 3, 2026

The status widget in mps-sync-plugin3 rendered Synchronizing: null when sync progress was unavailable for a branch. This change preserves the existing label when progress exists and falls back to Synchronizing when it does not.

  • Status text formatting

    • Route syncing label rendering through a dedicated formatter.
    • Return Synchronizing for null progress.
    • Keep Synchronizing: <progress> unchanged for non-null progress.
  • Regression coverage

    • Add focused tests for both null and non-null syncing progress text.
internal fun formatSyncingStatusText(progress: String?): String {
    return progress?.let { "Synchronizing: $it" } ?: "Synchronizing"
}

@abstraktor
Copy link
Copy Markdown
Collaborator

@copilot reword the commits to satisfy the commit linter

Copy link
Copy Markdown
Author

Copilot AI commented Jun 3, 2026

@copilot reword the commits to satisfy the commit linter

Locally rewritten the two commit messages as 48420aa7 and 052c24b5, and they pass commitlint. The available push path here only does fast-forward pushes, so the non-fast-forward update needed to replace the existing commits was rejected.

Copilot AI requested a review from abstraktor June 3, 2026 11:33
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 3, 2026

Test Results

  256 files  +1    256 suites  +1   50m 32s ⏱️ + 1m 11s
1 468 tests +2  1 457 ✅ +2  11 💤 ±0  0 ❌ ±0 
1 478 runs  +2  1 467 ✅ +2  11 💤 ±0  0 ❌ ±0 

Results for commit 93996d8. ± Comparison against base commit 7b66c35.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 3, 2026

JVM coverage report

Overall Project 59.49% -0.01%
Files changed 52.38%

File Coverage
ModelSyncStatusWidget.kt 2.08% -1.39%

@abstraktor abstraktor force-pushed the copilot/fix-synchronizing-message branch from 8aac8ea to 93996d8 Compare June 3, 2026 14:45
@abstraktor abstraktor marked this pull request as ready for review June 3, 2026 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants