fix(desktop): unblock versioned release builds - #86
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Unblocks Desktop Release workflow dry-runs for post-0.2.0 versions by removing stale validation assumptions and aligning the smoke test with the actual bundled runtime layout.
Changes:
- Removes the hardcoded
0.2.0version assertion from the desktop release contract checks. - Updates the macOS packaged-app smoke check to read the runtime manifest from the bundled
openworkruntime directory.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/desktop-shell/scripts/test-release.js | Drops the fixed version assertion in desktop release contract validation. |
| packages/desktop-shell/scripts/smoke-packaged.js | Fixes macOS runtime manifest path to match the bundled openwork runtime location. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
115
to
117
| assert.equal(config.productName, 'OpenWork'); | ||
| assert.equal(config.identifier, 'com.alibaba.openwork'); | ||
| assert.equal(config.version, '0.2.0'); | ||
| assert.equal(config.build.devUrl, 'http://127.0.0.1:1420'); |
Contributor
Code Coverage Summary
CLI Package - Full Text ReportCore Package - Full Text ReportFor detailed HTML reports, please see the 'coverage-reports-22.x-ubuntu-latest' artifact from the main CI run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Allows desktop release validation to accept the requested release version instead of requiring
0.2.0, and checks the packaged runtime manifest at its actual bundled location.Why it's needed
Desktop release dry-runs for versions after
0.2.0failed first during release validation and then during the packaged-app smoke check, preventing otherwise valid installers from completing CI.Reviewer Test Plan
How to verify
Run the Desktop Release workflow in dry-run mode with version
0.2.1. Confirm release validation succeeds, all four platform installer jobs complete, and publishing remains skipped.Evidence (Before & After)
Before: release validation rejected
0.2.1; after that was fixed, the smoke check searched for the runtime manifest under the wrong directory.After: Desktop Release run 32141936155 completed successfully for macOS Apple Silicon, macOS Intel, Windows x64, and Linux x64. Publish jobs were skipped because this was a dry-run.
Tested on
Environment (optional)
GitHub Actions Desktop Release dry-run, version
0.2.1, Electron migration bridge enabled.Risk & Scope
Linked Issues
N/A
中文说明
这个 PR 做了什么
桌面端发布校验不再把版本固定为
0.2.0，而是接受本次指定的发布版本；同时在安装包中实际的打包位置检查运行时清单。为什么需要
0.2.0之后版本的桌面端发布 dry-run 会先在版本校验阶段失败；修复后又会因为安装包冒烟检查查找了错误的运行时目录而失败，导致本来有效的安装包无法完成 CI。Reviewer Test Plan
如何验证
以版本
0.2.1和 dry-run 模式运行 Desktop Release workflow。确认发布校验成功、四个平台安装包任务全部完成，并且发布步骤仍然被跳过。证据（修复前后）
修复前：发布校验拒绝
0.2.1；修复这一点后，冒烟检查又在错误的目录中查找运行时清单。修复后：Desktop Release run 32141936155 已在 macOS Apple Silicon、macOS Intel、Windows x64 和 Linux x64 上全部成功。因为本次是 dry-run，发布任务被跳过。
测试平台
环境（可选）
GitHub Actions Desktop Release dry-run，版本
0.2.1，启用 Electron 迁移桥。风险与范围
关联 Issue
无