Skip to content

fix(release): publish signed builds without Windows certificate #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yiliang114 merged 1 commit into from
Aug 18, 2026
Merged

fix(release): publish signed builds without Windows certificate #87

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions .github/scripts/create-desktop-update-manifest.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,11 +23,15 @@ const platformArtifacts = [
'darwin-x86_64',
),
],
['windows-x86_64', selectArtifact(assets, /-setup\.exe$/i, 'windows-x86_64')],
[
'windows-x86_64',
selectArtifact(assets, /-setup\.exe$/i, 'windows-x86_64', true),
],
['linux-x86_64', selectArtifact(assets, /\.AppImage$/i, 'linux-x86_64')],
];

for (const [platform, artifact] of platformArtifacts) {
if (!artifact) continue;
Comment on lines 33 to +34

@chatgpt-codex-connector chatgpt-codex-connector Bot Aug 18, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Keep a valid updater entry for Windows clients

When a stable publish has no Windows artifact, this branch removes windows-x86_64 from latest.json, after which .github/workflows/desktop-build.yml:368-391 clobbers the shared desktop-latest feed with that incomplete manifest. Windows Tauri builds use this exact endpoint through packages/desktop-shell/src-tauri/tauri.conf.json:72-75, so their updater has no matching platform descriptor and update checks fail until a later release restores one. Use platform-specific feeds or otherwise avoid replacing the Windows-consumed feed with a manifest that lacks Windows.

Useful? React with 👍 / 👎.

const signatureFile = `${artifact}.sig`;
if (!assets.includes(signatureFile)) {
throw new Error(`Missing updater signature for ${artifact}`);
Expand All @@ -47,8 +51,9 @@ const manifest = {
};
fs.writeFileSync(options.output, `${JSON.stringify(manifest, null, 2)}\n`);

function selectArtifact(assets, pattern, platform) {
function selectArtifact(assets, pattern, platform, optional = false) {
const matches = assets.filter((asset) => pattern.test(asset));
if (optional && matches.length === 0) return undefined;
if (matches.length !== 1) {
throw new Error(
`Expected one updater artifact for ${platform}, found ${matches.length}: ${matches.join(', ')}`,
Expand Down
22 changes: 7 additions & 15 deletions .github/workflows/desktop-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,21 +35,10 @@ jobs:
strategy:
fail-fast: false
matrix:
include:
- name: 'macOS Apple Silicon'
os: 'macos-15'
target: 'aarch64-apple-darwin'
legacy_arch: 'arm64'
- name: 'macOS Intel'
os: 'macos-15-intel'
target: 'x86_64-apple-darwin'
legacy_arch: 'x64'
- name: 'Windows x64'
os: 'windows-2025'
target: 'x86_64-pc-windows-msvc'
- name: 'Linux x64'
os: 'ubuntu-22.04'
target: 'x86_64-unknown-linux-gnu'
include: >-
${{ fromJSON(inputs.publish &&
'[{"name":"macOS Apple Silicon","os":"macos-15","target":"aarch64-apple-darwin","legacy_arch":"arm64"},{"name":"macOS Intel","os":"macos-15-intel","target":"x86_64-apple-darwin","legacy_arch":"x64"},{"name":"Linux x64","os":"ubuntu-22.04","target":"x86_64-unknown-linux-gnu"}]' ||
'[{"name":"macOS Apple Silicon","os":"macos-15","target":"aarch64-apple-darwin","legacy_arch":"arm64"},{"name":"macOS Intel","os":"macos-15-intel","target":"x86_64-apple-darwin","legacy_arch":"x64"},{"name":"Windows x64","os":"windows-2025","target":"x86_64-pc-windows-msvc"},{"name":"Linux x64","os":"ubuntu-22.04","target":"x86_64-unknown-linux-gnu"}]') }}
steps:
- name: 'Check out source'
uses: 'actions/checkout@df4cb1c069e1874edd31b4311f1884172cec0e10' # v6.0.3
Expand Down Expand Up @@ -352,6 +341,9 @@ jobs:
for manifest in macos:latest-mac.yml windows:latest.yml linux:latest-linux.yml; do
platform="${manifest%%:*}"
output="${manifest#*:}"
if [[ "$platform" == 'windows' ]] && ! compgen -G 'release-assets/*-setup.exe' >/dev/null; then
continue
Comment on lines +344 to +345

@chatgpt-codex-connector chatgpt-codex-connector Bot Aug 18, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Preserve the Windows Electron bridge feed

When a non-draft, non-prerelease release is published with the default electron_bridge=true, these lines omit latest.yml, but the same workflow still passes --latest at line 363. gh release create --help defines --latest as “Mark this release as Latest,” while docs/design/desktop-electron-to-tauri-update-bridge.md:5 confirms that Windows Electron clients read latest.yml from the latest stable release. Those clients will therefore fail their update check instead of continuing to use the previous compatible bridge release; avoid marking this partial bridge release as Latest or retain a valid Windows bridge feed.

Useful? React with 👍 / 👎.

fi
node .github/scripts/create-electron-bridge-manifest.mjs --assets release-assets --platform "$platform" --version "$RELEASE_VERSION" --output "release-assets/$output"
done
fi
Expand Down
53 changes: 53 additions & 0 deletions packages/desktop-shell/scripts/test-release.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,14 @@ const electronBridgeScript = path.join(
'scripts',
'create-electron-bridge-manifest.mjs',
);
const desktopUpdateScript = path.join(
packageDir,
'..',
'..',
'.github',
'scripts',
'create-desktop-update-manifest.mjs',
);
const root = fs.mkdtempSync(
path.join(os.tmpdir(), 'openwork-desktop-release-test-'),
);
Expand All @@ -32,6 +40,7 @@ try {
testMacosPermissions();
testReleaseWorkflow();
testRuntimePreparationContract();
testDesktopUpdateManifest(path.join(root, 'desktop-update'));
testElectronBridgeManifest(path.join(root, 'electron-bridge'));
testChecksumRefresh(path.join(root, 'checksums'));
testVersionSynchronization(path.join(root, 'version'));
Expand Down Expand Up @@ -258,10 +267,54 @@ function testReleaseWorkflow() {
/if: '?inputs\.dry_run == false'?[\s\S]*contents: '?write'?/,
);
assert.match(publishJob, /secrets: '?inherit'?/);
const matrices = buildWorkflow.match(
/fromJSON\(inputs\.publish &&\s*'([^']+)' \|\|\s*'([^']+)'\)/,
);
assert.ok(matrices);
assert.equal(
JSON.parse(matrices[1]).some(({ os }) => os.startsWith('windows-')),
false,
);
assert.equal(
JSON.parse(matrices[2]).some(({ os }) => os.startsWith('windows-')),
true,
);
assert.doesNotMatch(workflow, /uses: [^\n]+@(v\d|stable)\b/);
assert.doesNotMatch(workflow, /push --force|force-with-lease/);
}

function testDesktopUpdateManifest(directory) {
const assets = path.join(directory, 'assets');
const output = path.join(directory, 'latest.json');
fs.mkdirSync(assets, { recursive: true });
for (const artifact of [
'OpenWork-aarch64-apple-darwin.app.tar.gz',
'OpenWork-x86_64-apple-darwin.app.tar.gz',
'OpenWork_0.2.1_amd64.AppImage',
]) {
fs.writeFileSync(path.join(assets, artifact), artifact);
fs.writeFileSync(path.join(assets, `${artifact}.sig`), `signature:${artifact}`);
}
execFileSync(process.execPath, [
desktopUpdateScript,
'--assets',
assets,
'--repository',
'modelstudioai/openwork',
'--tag',
'openwork-v0.2.1',
'--version',
'0.2.1',
'--output',
output,
]);
assert.deepEqual(Object.keys(JSON.parse(fs.readFileSync(output)).platforms), [
'darwin-aarch64',
'darwin-x86_64',
'linux-x86_64',
]);
}

function testElectronBridgeManifest(directory) {
const assets = path.join(directory, 'assets');
fs.mkdirSync(assets, { recursive: true });
Expand Down
Loading