fix(session): time out daemon CLI calls

[benvinegar]

Summary

• Add a shared timeout wrapper for session-daemon HTTP calls.
• Route session capabilities and every hunk session * API request through that wrapper.
• Cover hung capability/API calls, including operations that ignore abort signals or hang while parsing the response.

Fixes #406.

Testing

• bun run lint
• bun run typecheck
• bun run format:check
• bun test ./src ./packages ./scripts ./test/cli ./test/session

This PR description was generated by Pi using OpenAI GPT-5

[greptile-apps]

Greptile Summary

This PR adds a shared timeout wrapper (withSessionDaemonHttpTimeout) and a convenience HTTP helper (requestSessionDaemonHttp) so that all hunk session * daemon calls — including capabilities negotiation — fail fast after 5 seconds instead of hanging indefinitely when the daemon is unresponsive.

• New src/session/daemonHttp.ts: introduces withSessionDaemonHttpTimeout (races a task against a setTimeout-backed abort) and requestSessionDaemonHttp (wraps fetch + response parsing inside that timeout), with the timeout covering the full lifecycle, not just the initial connect.
• capabilities.ts and cli.ts refactored: both route their fetch calls through requestSessionDaemonHttp, and readHunkSessionDaemonCapabilities now accepts an optional timeoutMs parameter forwarded from the CLI client constructor.
• Test coverage: new tests in all three test files verify both the "stub-born task that ignores abort" path in withSessionDaemonHttpTimeout and the "parse hangs after fetch returns" path in requestSessionDaemonHttp; globalThis.fetch is properly saved and restored via afterEach in both cli.test.ts and capabilities.test.ts.

Confidence Score: 5/5

Safe to merge — the change is well-scoped and all existing null-return paths in capabilities.ts are preserved inside the parse callback.

The timeout logic is correctly layered: the AbortController fires first, both the fetch and the Promise.race reject with the same timeoutError, and the finally block suppresses any late rejection from tasks that ignore the abort signal. The parse callback keeps the timeout clock running through body consumption, which is the subtle edge case the PR set out to fix. Test coverage exercises all three layers — stub-born tasks, hung fetches, and hung parses — and globalThis.fetch is properly restored in afterEach in every affected test file.

No files require special attention.

Important Files Changed

Filename	Overview
src/session/daemonHttp.ts	New file introducing withSessionDaemonHttpTimeout and requestSessionDaemonHttp; implementation correctly covers the full fetch + parse lifecycle, handles tasks that ignore abort signals via Promise.race, and suppresses late rejections from aborted tasks in the finally block.
src/session/capabilities.ts	Refactored to route the capabilities fetch through requestSessionDaemonHttp; all existing null-return paths preserved inside the parse callback; adds optional timeoutMs parameter.
src/hunk-session/cli.ts	HttpHunkSessionCliClient gains a timeoutMs constructor param (defaulting to HUNK_SESSION_DAEMON_HTTP_TIMEOUT_MS); request() and getCapabilities() both route through the new timeout wrappers; factory function updated to accept optional config object.
src/session/daemonHttp.test.ts	New test file covering both the abort-ignoring task path and the hung-parse-after-fetch path; globalThis.fetch is saved and restored correctly within each test.
src/session/capabilities.test.ts	Adds a timeout test for readHunkSessionDaemonCapabilities with a mock fetch; correctly saves/restores globalThis.fetch in afterEach alongside the existing real-server cleanup.
src/hunk-session/cli.test.ts	Adds AbortSignal assertion to the existing happy-path test and a new timeout test for listSessions; globalThis.fetch cleanup moved to a top-level afterEach, properly covering all test cases in the file.
CHANGELOG.md	Adds a user-facing entry for the daemon timeout fix under the current unreleased section.

Sequence Diagram

sequenceDiagram
    participant Caller
    participant withSessionDaemonHttpTimeout
    participant task/fetch
    participant setTimeout

    Caller->>withSessionDaemonHttpTimeout: call(operation, timeoutMs, task)
    withSessionDaemonHttpTimeout->>setTimeout: schedule abort after timeoutMs
    withSessionDaemonHttpTimeout->>task/fetch: start task(signal)
    Note over withSessionDaemonHttpTimeout: Promise.race([taskPromise, timeoutPromise])

    alt Task completes before timeout
        task/fetch-->>withSessionDaemonHttpTimeout: resolve(result)
        withSessionDaemonHttpTimeout->>setTimeout: clearTimeout()
        withSessionDaemonHttpTimeout-->>Caller: return result
    else Timeout fires first
        setTimeout->>withSessionDaemonHttpTimeout: controller.abort(timeoutError)
        setTimeout->>withSessionDaemonHttpTimeout: reject(timeoutError)
        withSessionDaemonHttpTimeout->>task/fetch: abort signal fires
        Note over task/fetch: task may reject later — suppressed via .catch()
        withSessionDaemonHttpTimeout-->>Caller: throw HunkUserError("Timed out…")
    end

Loading

_{Reviews (1): Last reviewed commit: "fix(session): time out daemon CLI calls" | Re-trigger Greptile}